Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specialize haszero for Union{Missing,<:Number} #56169

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Specialize haszero for Union{Missing,<:Number} #56169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d01e1a1
Specialize haszero for Union{Missing,<:Number} types
jishnub Oct 15, 2024
8dd4751
Merge branch 'master' into jishnub/_zero_missing
jishnub Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stdlib/LinearAlgebra/src/dense.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ norm2(x::Union{Array{T},StridedVector{T}}) where {T<:BlasFloat} =
# Conservative assessment of types that have zero(T) defined for themselves
haszero(::Type) = false
haszero(::Type{T}) where {T<:Number} = isconcretetype(T)
haszero(::Type{Union{Missing,T}}) where {T<:Number} = haszero(T)
@propagate_inbounds _zero(M::AbstractArray{T}, inds...) where {T} = haszero(T) ? zero(T) : zero(M[inds...])

"""
Expand Down
8 changes: 8 additions & 0 deletions stdlib/LinearAlgebra/test/triangular.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1284,6 +1284,14 @@ end
@test istril(U, k) == istril(A, k)
end
end

@testset "Union eltype" begin
M = Matrix{Union{Int,Missing}}(missing,2,2)
U = triu(M)
@test iszero(U[2,1])
U = tril(M)
@test iszero(U[1,2])
end
end

@testset "indexing with a BandIndex" begin
Expand Down