[CRC32c] Support AbstractVector{UInt8} as input #56164
Open
+49
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhz2
commented
Oct 14, 2024
| @@ -51,6 +51,5 @@ mixed with a starting `crc` integer. If `nb` is not supplied, then | |||
| """ | |||
| crc32c(io::IO, nb::Integer, crc::UInt32=0x00000000) = Base._crc32c(io, nb, crc) | |||
| crc32c(io::IO, crc::UInt32=0x00000000) = Base._crc32c(io, crc) | |||
| crc32c(io::IOStream, crc::UInt32=0x00000000) = Base._crc32c(io, crc) | |||
There was a problem hiding this comment.
This method is redundant with the method above.
nhz2
commented
Oct 14, 2024
| @@ -30,13 +29,14 @@ calling [`take!`](@ref). | |||
|
|
|||
| For a `String`, note that the result is specific to the UTF-8 encoding | |||
| (a different checksum would be obtained from a different Unicode encoding). | |||
| To checksum an `a::Array` of some other bitstype, you can do `crc32c(reinterpret(UInt8,a))`, | |||
There was a problem hiding this comment.
This doesn't work if a has padding or is multidimensional. I updated the docstring to note that a must not have padding, and that vec should be used in addition to reinterpret(UInt8.
Seelengrab
reviewed
Oct 14, 2024
stevengj
reviewed
Oct 14, 2024
stevengj
reviewed
Oct 14, 2024
stevengj
reviewed
Oct 14, 2024
Co-authored-by: Steven G. Johnson <[email protected]>
stevengj
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a similar PR to JuliaIO/CRC32.jl#12
I added a generic fallback method for
AbstractVector{UInt8}similar to the existing genericIOmethod.