Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly store a module's location #55963

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Explicitly store a module's location #55963

merged 1 commit into from
Oct 2, 2024

Commits on Oct 2, 2024

  1. Explicitly store a module's location

    Revise wants to know what file a module's `module` definition is in.
    Currently it does this by looking at the source location for the
    implicitly generated `eval` method. This is terrible for two reasons:
    
    1. The method may not exist if the module is a baremodule (which is not
       particularly common, which is probably why we haven't seen it).
    2. The fact that the implicitly generated `eval` method has this location
       information is an implementation detail that I'd like to get rid of
       (#55949).
    
    This PR adds explicit file/line info to `Module`, so that Revise doesn't
    have to use the hack anymore.
    Keno committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6496c47 View commit details
    Browse the repository at this point in the history