Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Various fixes to byte / bytearray search" #55733

Closed
wants to merge 1 commit into from
Closed

Revert "Various fixes to byte / bytearray search" #55733

wants to merge 1 commit into from

Conversation

giordano
Copy link
Contributor

Reverts #54579

@giordano giordano added the revert This reverts a previously merged PR. label Sep 10, 2024
@giordano
Copy link
Contributor Author

@jakobnissen #54579 was merged but the last rebase on master was 3 months ago, and probably there have been conflicting changes since. I'm sure there's a way to more specifically fix the breakage and keep your other good changes, but it's also urgent to get CI back to green.

@nhz2
Copy link
Contributor

nhz2 commented Sep 11, 2024

I have a more targeted fix in #55734 that is passing all the strings tests locally.

@aviatesk
Copy link
Member

I guess we can close this now in favor of #55734?

@aviatesk aviatesk closed this Sep 11, 2024
@giordano giordano deleted the revert-54579-byte_int branch September 11, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
revert This reverts a previously merged PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giordano @nhz2 @aviatesk