module: Prepare usings array for world age partition
#55357
Merged
+83
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
force-pushed
the
kf/usingspartition
branch
from
b230190
to
9ecb249
Compare
Keno
force-pushed
the
kf/usingspartition
branch
from
9ecb249
to
9041a36
Compare
This is a relatively independent part of the bindings partition branch, extending the module usings list to gain `min_world` and `max_world` `size_t`s. These are always `0` and `(size_t)-1` respectively in this PR, which handles the GC and serialization implications of this change. The semantic part will come later.
Keno
force-pushed
the
kf/usingspartition
branch
from
9041a36
to
e2a7846
Compare
vtjnash
reviewed
Oct 17, 2024
Comment on lines
+755
to
+756
| arraylist_grow(&to->usings, sizeof(struct _jl_module_using)/sizeof(void*)); | ||
| memcpy(&to->usings.items[to->usings.len-3], &new_item, sizeof(struct _jl_module_using)); |
There was a problem hiding this comment.
IIUC, you don't always access this state with a lock (e.g. in jl_module_names), so this is a concurrency issue. The simplest fix is to make sure there add a lock (like using_resolve_binding does). The alternative fix is to use the similar functions in mtarraylist.c which should allow concurrent reading
KristofferC
pushed a commit
that referenced
this pull request
Oct 21, 2024
This is a relatively independent part of the bindings partition branch, extending the module usings list to gain `min_world` and `max_world` `size_t`s. These are always `0` and `(size_t)-1` respectively in this PR, which handles the GC and serialization implications of this change. The semantic part will come later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively independent part of the bindings partition branch, extending the module usings list to gain
min_worldandmax_worldsize_ts. These are always0and(size_t)-1respectively in this PR, which handles the GC and serialization implications of this change. The semantic part will come later.