Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove JuliaSyntaxHighlighting from 1.11 #55217

Merged
merged 1 commit into from
Jul 23, 2024
Merged

remove JuliaSyntaxHighlighting from 1.11 #55217

merged 1 commit into from
Jul 23, 2024

Conversation

KristofferC
Copy link
Member

Fixes #55023

tecosaur
tecosaur approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@tecosaur tecosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing these changes to #51810, this looks right to me 👍

@KristofferC KristofferC merged commit f4b4376 into backports-release-1.11 Jul 23, 2024
5 of 7 checks passed
@KristofferC KristofferC deleted the kc/rem_Juliasyntax branch July 23, 2024 15:45
@christiangnrd
Copy link
Contributor

This PR seems to have been reverted when the branch was last force-pushed. Was that intentional?

@KristofferC
Copy link
Member Author

No, thanks for catching that. I am surprised that --force-with-lease didn't catch that. Or maybe I missed using it..

KristofferC added a commit that referenced this pull request Jul 25, 2024
@KristofferC
remove JuliaSyntaxHighlighting from 1.11 (#55217)
c2dcb7e 
Fixes #55023
@christiangnrd christiangnrd mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tecosaur tecosaur tecosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KristofferC @christiangnrd @tecosaur