-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REPL: add lock to orchestrate adding repl modes etc. #54890
base: master
Are you sure you want to change the base?
REPL: add lock to orchestrate adding repl modes etc. #54890
Conversation
Taking a lock here does not help with the general unsoundness of this being written inside an |
So you're saying there's no valid way to initialize the repl mode automatically when calling |
Correct. Arbitrarily mutating some random global state during |
Pkg aside, if we take a 3rd party package that adds a repl mode, what's the valid way for a user to initialize then? startup.jl
and in the REPL itself
In particular, is the latter any better for knowing that the init is happening during the correct repl state? I thought a lock was a logical fix here. Maybe there are more places in REPL that should take the lock. cc. @KristofferC given discussion in JuliaLang/Pkg.jl#3933 |
I do think the lock is an improvement here. Should we move forward with this, or is there some other automatic initializing method other than |
Bump |
38c3530
to
4685584
Compare
Fixes #54889
Fixes JuliaLang/Pkg.jl#3933
Pkg changes: JuliaLang/Pkg.jl@master...IanButterworth:Pkg.jl:ib/repl_mutate_lock