Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up #54772 - don't accidentally put Module into method name slot #54856

Merged
merged 1 commit into from
Jun 23, 2024

Commits on Jun 23, 2024

  1. Follow up #54772 - don't accidentally put Module into method name slot

    The `:outerref` removal (#54772) ended up accidentally putting a `Module`
    argument into 3-argument `:method` due to a bad refactor. We didn't catch
    this in the tests, because the name slot of 3-argument `:method` is
     unused (except for external method tables), but ordinarily contains
    the same data as 1-argument `:method`.
    That said, some packages in the Revise universe look at this
    (arguably incorrectly, since they should be looking at the
    signature instead), so it should be correct until we fix Revise,
    at which point we may just want to always pass `false` here.
    Keno committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    5262090 View commit details
    Browse the repository at this point in the history