-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes to byte / bytearray search #54579
Merged
Merged
+170
−47
Commits on Jun 4, 2024
-
Convert UInt8 and Int8 to common types in when searching
This fixes an issue introduced in commit 5d8225a where you wrongly have `findfirst(==(0xff), Int8[-1]) == 1`. Also, use safer and more efficient conversion of AbstractChar to UInt8. Also, allow SubString{String} in more string search functions.
Configuration menu - View commit details
-
Copy full SHA for b1388d5 - Browse repository at this point
Copy the full SHA b1388d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6760c7b - Browse repository at this point
Copy the full SHA 6760c7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for dcba576 - Browse repository at this point
Copy the full SHA dcba576View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0da6f3 - Browse repository at this point
Copy the full SHA a0da6f3View commit details -
Apply suggestions from code review
Remove needless <: in union types Co-authored-by: Martin Holters <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9aa7958 - Browse repository at this point
Copy the full SHA 9aa7958View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5c740e - Browse repository at this point
Copy the full SHA c5c740eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ccc2db2 - Browse repository at this point
Copy the full SHA ccc2db2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0540fdf - Browse repository at this point
Copy the full SHA 0540fdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for f864503 - Browse repository at this point
Copy the full SHA f864503View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9518d66 - Browse repository at this point
Copy the full SHA 9518d66View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbef9b0 - Browse repository at this point
Copy the full SHA fbef9b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3268012 - Browse repository at this point
Copy the full SHA 3268012View commit details
Commits on Jun 13, 2024
-
It's more Julian to return nothing directly from the search function.
Configuration menu - View commit details
-
Copy full SHA for b65434c - Browse repository at this point
Copy the full SHA b65434cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29c5874 - Browse repository at this point
Copy the full SHA 29c5874View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.