Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes to byte / bytearray search #54579

Merged
merged 14 commits into from
Sep 10, 2024
Merged

Various fixes to byte / bytearray search #54579

merged 14 commits into from
Sep 10, 2024
+170 −47

Commits on Jun 4, 2024

  1. Convert UInt8 and Int8 to common types in when searching 

    This fixes an issue introduced in commit 5d8225a where you wrongly have
`findfirst(==(0xff), Int8[-1]) == 1`.
Also, use safer and more efficient conversion of AbstractChar to UInt8.
Also, allow SubString{String} in more string search functions.
    @jakobnissen
    jakobnissen committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    b1388d5 View commit details
    Browse the repository at this point in the history

  2. Add tests and fixup union vector search

    @jakobnissen
    jakobnissen committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    6760c7b View commit details
    Browse the repository at this point in the history

  3. Small fixes

    @jakobnissen
    jakobnissen committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    dcba576 View commit details
    Browse the repository at this point in the history

  4. Fix bug in search for invalid characters

    @jakobnissen
    jakobnissen committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    a0da6f3 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Remove needless <: in union types

Co-authored-by: Martin Holters <[email protected]>
    @jakobnissen @martinholters
    jakobnissen and martinholters committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9aa7958 View commit details
    Browse the repository at this point in the history

  6. Address reviews: Sizeof

    @jakobnissen
    jakobnissen committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c5c740e View commit details
    Browse the repository at this point in the history

  7. Test with dense offset arrays

    @jakobnissen
    jakobnissen committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ccc2db2 View commit details
    Browse the repository at this point in the history

  8. Fix off-by-one in memrchr

    @jakobnissen
    jakobnissen committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0540fdf View commit details
    Browse the repository at this point in the history

  9. Fix testhelper path

    @jakobnissen
    jakobnissen committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    f864503 View commit details
    Browse the repository at this point in the history

  10. Fixup path

    @jakobnissen
    jakobnissen committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9518d66 View commit details
    Browse the repository at this point in the history

  11. Please work

    @jakobnissen
    jakobnissen committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    fbef9b0 View commit details
    Browse the repository at this point in the history

  12. Remove unused ByteArray

    @jakobnissen
    jakobnissen committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    3268012 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Remove nothing_sentinel 

    It's more Julian to return nothing directly from the search function.
    @jakobnissen
    jakobnissen committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    b65434c View commit details
    Browse the repository at this point in the history

  2. Commit suggestions

    @jakobnissen
    jakobnissen committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    29c5874 View commit details
    Browse the repository at this point in the history