improve allunique's type stability (#56161)

Caught by aviatesk/JET.jl#667.
JuliaLang · Oct 15, 2024 · fe82988 · fe82988
1 parent 0af99e6
commit fe82988
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/base/set.jl b/base/set.jl
@@ -549,8 +549,8 @@ function allunique(A::StridedArray)
     if length(A) < 32
         _indexed_allunique(A)
     elseif OrderStyle(eltype(A)) === Ordered()
-        a1, rest1 = Iterators.peel(A)
-        a2, rest = Iterators.peel(rest1)
+        a1, rest1 = Iterators.peel(A)::Tuple{Any,Any}
+        a2, rest = Iterators.peel(rest1)::Tuple{Any,Any}
         if !isequal(a1, a2)
             compare = isless(a1, a2) ? isless : (a,b) -> isless(b,a)
             for a in rest

diff --git a/test/sets.jl b/test/sets.jl
@@ -644,6 +644,7 @@ end
     @test !allunique((NaN, NaN))
     # Known length 1, need not evaluate:
     @test allunique(error(x) for x in [1])
+    # @test_opt allunique(Int[])
 end
 
 @testset "allunique(f, xs)" begin