Skip to content

Commit

Permalink
trimming: don't abort where we used to resolve dynamic calls (#56271)
Browse files Browse the repository at this point in the history
This call resolution code was deleted in #56179 (rightfully so), but it
should be a no-op until we implement this in inference.
  • Loading branch information
topolarity authored Oct 21, 2024
1 parent f976541 commit 1ba035d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/codegen.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5806,7 +5806,8 @@ static jl_cgval_t emit_call(jl_codectx_t &ctx, jl_expr_t *ex, jl_value_t *rt, bo
}
int failed_dispatch = !argv[0].constant;
if (ctx.params->trim != JL_TRIM_NO) {
abort(); // this code path is unsound, unsafe, and probably bad
// TODO: Implement the last-minute call resolution that used to be here
// in inference instead.
}

if (failed_dispatch && trim_may_error(ctx.params->trim)) {
Expand Down

0 comments on commit 1ba035d

Please sign in to comment.