Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use thread-safe conditions for connection pool #512

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Use thread-safe conditions for connection pool #512

merged 2 commits into from
Jun 5, 2023

Conversation

mosullivan93
Copy link
Contributor

I implement changes similar to Blink.jl#307 to fix concurrency errors when multithreaded in Julia 1.9 and interacting with a page's DOM using Blink.

Fixes Blink.jl#308, WebIO.jl#511, and KoraMRI.jl#168.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #512 (7697a72) into master (37f6f8b) will increase coverage by 1.42%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
+ Coverage   59.41%   60.84%   +1.42%     
==========================================
  Files          16       16              
  Lines         754      761       +7     
==========================================
+ Hits          448      463      +15     
+ Misses        306      298       -8     
Impacted Files Coverage Δ
src/connection.jl 90.69% <100.00%> (+1.80%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@beorostica
Copy link

We are really interested in using this feature soon for KomaMRI.jl.
When would this be merged in a new version of WebIO and updated in the julia registries?

@shashi shashi merged commit 832e2b8 into JuliaGizmos:master Jun 5, 2023
@mosullivan93 mosullivan93 deleted the threadsafety branch June 6, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConcurrencyViolationError when using content! with Interact objects in Julia 1.9
3 participants