Subscribe to FeatureTrait() for Shapefile.Row #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests? |
asinghvi17
force-pushed
the
as/row_feature_explicit
branch
from
f6a9b84
to
823e837
Compare
rafaqz
approved these changes
Sep 23, 2024
asinghvi17
commented
Sep 24, 2024
| @@ -111,6 +111,7 @@ wkt = "GEOGCS[\"GCS_WGS_1984\",DATUM[\"D_WGS_1984\",SPHEROID[\"WGS_1984\",637813 | |||
| @test size(df_land) == (127, 4) | |||
| @test names(df_land) == ["geometry", "featurecla", "scalerank", "min_zoom"] | |||
| df_land.featurecla isa Vector{Union{String,Missing}} | |||
| @test GeoInterface.trait(GeoInterface.getfeature(ne_land, 1)) isa GeoInterface.FeatureTrait | |||
There was a problem hiding this comment.
This is failing because Table doesn't have a featurecollection trait. I guess we could just subset the table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not explicit before and so was a problem.