add z_index function #24
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
reviewed
Jan 22, 2023
Comment on lines
+118
to
+119
| We assume tiles are the standard 256*256 pixels. Note that this is not an | ||
| enforced standard, and that retina tiles are 512*512. |
There was a problem hiding this comment.
Perhaps it's best to directly add the tile size as an argument?
There was a problem hiding this comment.
Ok I considered that too. I guess a keyword with default is best.
Co-authored-by: Martijn Visser <[email protected]>
asinghvi17
reviewed
Apr 23, 2024
| We assume tiles are the standard 256*256 pixels. Note that this is not an | ||
| enforced standard, and that retina tiles are 512*512. | ||
| """ | ||
| function z_index(extent::Extent, res::NamedTuple, crs::WebMercator) |
There was a problem hiding this comment.
Should this also accept tuples (x, y) as Makie does? In that case we can also make z_index(..., Tuple) = z_index(..., (; X = ..., Y = ...)) or so.
There was a problem hiding this comment.
There should probably also be a catchall method to error when crs is not WebMercator (for now...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function to get the z index for a specific extent and resolution.
Needs tests