Skip to content

Commit

Permalink
work-around for #17
Browse files Browse the repository at this point in the history
  • Loading branch information
Alexander-Barth authored Jan 31, 2024
1 parent ce5bf11 commit e96d9ec
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion src/variable.jl
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,18 @@ Default fill-value for the given type from NetCDF.
_nonuniontype(::Type{T},::Type{Union{T,S}}) where {T,S} = S
function nonuniontype(T,TS)
if typeof(TS) == Union
_nonuniontype(T,TS)
# https://github.com/JuliaLang/julia/issues/53136
@static if (VERSION < v"1.8") && Sys.iswindows()
if TS.a == T
return TS.b
elseif TS.b == T
return TS.a
else
return TS
end
else
_nonuniontype(T,TS)
end
else
TS
end
Expand Down

2 comments on commit e96d9ec

@Alexander-Barth
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/99945

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.3.4 -m "<description of version>" e96d9ecf11743f1aea9e1b8ab05e58adc9057418
git push origin v0.3.4

Please sign in to comment.