fix deprecation of dtc

JuliaGaussianProcesses · Sep 23, 2023 · 3bb0d80 · 3bb0d80
1 parent 92456df
commit 3bb0d80
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/src/deprecations.jl b/src/deprecations.jl
@@ -6,5 +6,17 @@
     plt, gp; samples=n, kwargs...
 )
 
-@deprecate elbo(dtc::DTC, fx, y) approx_log_evidence(dtc, fx, y)
-@deprecate dtc(vfe::Union{VFE,DTC}, fx, y) approx_log_evidence(vfe, fx, y)
+@deprecate dtc(dtc::DTC, fx, y) approx_log_evidence(dtc, fx, y)
+
+function _warn_elbo_called_with_DTC(dtc::DTC, fx, y)
+    @warn "`elbo` was called with an object of type `DTC`, but should only be called with the `VFE` type instead"
+    return elbo(VFE(dtc.fz), fx, y)
+end
+
+function _warn_dtc_called_with_VFE(vfe::VFE, fx, y)
+    @warn "`dtc` was called with an object of type `VFE`, but instead you should call `approx_log_evidence` with an object of type `DTC`"
+    return approx_log_evidence(DTC(vfe.fz), fx, y)
+end
+
+@deprecate elbo(dtc::DTC, fx, y) _warn_elbo_called_with_DTC(dtc, fx, y)
+@deprecate dtc(vfe::VFE, fx, y) _warn_dtc_called_with_VFE(vfe, fx, y)