-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing double prefixes bug in produce_or_load #393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix. I think the test can be set up better.
I managed to run and pass the tests locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I will merge as soon as tests pass!
Codecov Report
@@ Coverage Diff @@
## main #393 +/- ##
==========================================
- Coverage 90.69% 90.57% -0.13%
==========================================
Files 8 8
Lines 752 753 +1
==========================================
Hits 682 682
- Misses 70 71 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
See #392
I also created a test, but I was unable to test it locally. Each time I ran tests
BSON
package was uninstalled, and the lack of this package produced errors, and further tests were unable to be run. The issue might be with the system not making a distinction between a system package and a local one.