Skip to content

Commit

Permalink
Add rrule for NamedTuple merge
Browse files Browse the repository at this point in the history
  • Loading branch information
oxinabox committed May 20, 2024
1 parent 2c6621c commit a05ebb2
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 0 deletions.
22 changes: 22 additions & 0 deletions src/rulesets/Base/base.jl
Original file line number Diff line number Diff line change
Expand Up @@ -291,3 +291,25 @@ function rrule(config::RuleConfig{>:HasReverseMode}, ::typeof(task_local_storage
end
return y, task_local_storage_pullback
end


####
#### merge
####

function rrule(::typeof(merge), nt1::NamedTuple{F1}, nt2::NamedTuple{F2}) where {F1, F2}
y = merge(nt1, nt2)
function merge_pullback(dy)
dnt1 = Tangent{typeof(nt1)}(;
(f1 => (f1 in F2 ? ZeroTangent() : getproperty(dy, f1)) for f1 in F1)...
)
dnt2 = Tangent{typeof(nt2)}(;
(f2 => getproperty(dy, f2) for f2 in F2)...
)
return (NoTangent(), dnt1, dnt2)
end
merge_pullback(dy::AbstractThunk) = merge_pullback(unthunk(dy))
merge_pullback(x::AbstractZero) = (NoTangent(), x, x)

return y, merge_pullback
end
5 changes: 5 additions & 0 deletions test/rulesets/Base/base.jl
Original file line number Diff line number Diff line change
Expand Up @@ -257,4 +257,9 @@ end
test_rrule(map, Multiplier(4.5), (6.7, 8.9), (0.1, 0.2, 0.3), check_inferred=false)
end
end

@testset "merge NamedTuple" begin
test_rrule(merge, (;a=1.0), (;b=2.0), check_inferred=false)
test_rrule(merge, (;a=1.0), (;a=2.0), check_inferred=false)
end
end

0 comments on commit a05ebb2

Please sign in to comment.