-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Fixing Julia tests #508
base: master
Are you sure you want to change the base?
Conversation
seems to make no significant difference. So is this the correct handling for a thunk? ``` newframe = Frame(moduleof(frame), code) if isa(recurse, Compiled) JuliaInterpreter.finish!(recurse, newframe, true) else newframe.caller = frame frame.callee = newframe ret = limited_exec!(recurse, newframe, refnstmts, istoplevel) isa(ret, Aborted) && return ret, refnstmts[] frame.callee = nothing end ```
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
==========================================
+ Coverage 82.76% 83.65% +0.89%
==========================================
Files 12 12
Lines 2443 2405 -38
==========================================
- Hits 2022 2012 -10
+ Misses 421 393 -28
Continue to review full report at Codecov.
|
These are the tests which seem to be most time consuming or not terminating:
|
Nice to see this getting worked on again! |
The current critical problem with |
... and reasonable results without aborting
I'm not sure how to proceed with this patch. In its original form it intended to make the tests runnable on Windows (BTW, is the repository version working on other platforms?). I'd be willing to revert it to this initial form in order to keep the changes small and establish a baseline for further improvements regarding #13. Is this the way to go? |
This commit contains the changes needed to make the tests running locally against the installed Julia tests.