Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fixing Julia tests #508

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

goerch
Copy link
Contributor

@goerch goerch commented Dec 10, 2021

This commit contains the changes needed to make the tests running locally against the installed Julia tests.

seems to make no significant difference. So is this the correct handling for a thunk?

```
                    newframe = Frame(moduleof(frame), code)
                    if isa(recurse, Compiled)
                        JuliaInterpreter.finish!(recurse, newframe, true)
                    else
                        newframe.caller = frame
                        frame.callee = newframe
                        ret = limited_exec!(recurse, newframe, refnstmts, istoplevel)
                        isa(ret, Aborted) && return ret, refnstmts[]
                        frame.callee = nothing
                    end
```
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #508 (50f35b6) into master (10fd8fc) will increase coverage by 0.89%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
+ Coverage   82.76%   83.65%   +0.89%     
==========================================
  Files          12       12              
  Lines        2443     2405      -38     
==========================================
- Hits         2022     2012      -10     
+ Misses        421      393      -28     
Impacted Files Coverage Δ
src/interpret.jl 81.02% <0.00%> (+9.04%) ⬆️
src/types.jl 67.51% <ø> (-5.74%) ⬇️
src/construct.jl 84.90% <62.50%> (-4.59%) ⬇️
src/optimize.jl 96.91% <0.00%> (-0.01%) ⬇️
src/precompile.jl 0.00% <0.00%> (ø)
src/utils.jl 85.47% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10fd8fc...50f35b6. Read the comment docs.

@goerch goerch changed the title Fixing Julia tests WIP: Fixing Julia tests Dec 11, 2021
@goerch
Copy link
Contributor Author

goerch commented Dec 12, 2021

These are the tests which seem to be most time consuming or not terminating:

interrupting channels
interrupting precompile
interrupting subtype
interrupting worlds

@KristofferC
Copy link
Member

Nice to see this getting worked on again!

@goerch
Copy link
Contributor Author

goerch commented Dec 12, 2021

The current critical problem with channels is reported in #153. For subtype I hit AssertionError("is_leaf(frame)") in step_expr!. In which of my branches do you want me to try to fix this?

@goerch
Copy link
Contributor Author

goerch commented Jan 1, 2022

Nice to see this getting worked on again!

I'm not sure how to proceed with this patch. In its original form it intended to make the tests runnable on Windows (BTW, is the repository version working on other platforms?). I'd be willing to revert it to this initial form in order to keep the changes small and establish a baseline for further improvements regarding #13. Is this the way to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants