Fixed failing doctests because of changes to Random.jl #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is suggested by the Documenter documentation. I was not able to locally run make.jl until I did this. (Actually the situation was worse because I was running the tests with a different version of the package than the local one, which was yielding confusing error messages.)
|
This is what I ran from within the DataFrames directory which updated the docs Project.toml file and enabled me to run (DataFrames) pkg> activate docs
(docs) pkg> dev .I'm not sure if that relationship is fully captured by the code in the Project.toml file. |
|
Now the behavior flipped so this branch is failing and #3360 passed??? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MersenneTwister(1234)from Random.jl yields different results now than those shown in the docstrings. I updated the docstrings ofshuffleandshuffle!so that their output matches the new results. I also had to modify thedocsProject.toml to be able to run the doctests correctly as suggested by Documenter.jl.This should fix the currently failing doctests in #3360.