Fix for #188 (#189)

* Fix for #188 * Tests for #188 * Added version guard for Julia 0.6 Fixes #188.
JuliaDSP · Mar 26, 2018 · 3cdd31a · 3cdd31a
1 parent b10ed24
commit 3cdd31a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/dspbase.jl b/src/dspbase.jl
@@ -53,8 +53,8 @@ function filt!(out::AbstractArray, b::Union{AbstractVector, Number}, a::Union{Ab
     # Filter coefficient normalization
     if a[1] != 1
         norml = a[1]
-        a ./= norml
-        b ./= norml
+        a = a ./ norml
+        b = b ./ norml
     end
     # Pad the coefficients with zeros if needed
     bs<sz   && (b = copyto!(zeros(eltype(b), sz), b))

diff --git a/test/dsp.jl b/test/dsp.jl
@@ -63,3 +63,17 @@ end
     @test conv(a, b) ≈ [1., 4., 8., 10., 7., 6.]
     @test conv(complex.(a, ones(4)), complex(b)) ≈ complex.([1., 4., 8., 10., 7., 6.], [1., 3., 6., 6., 5., 3.])
 end
+
+@testset "deconv" begin
+    # Test for issue #188: deconv mutates inputs
+    if VERSION >= v"0.7.0-DEV.602"
+        let b = [4.0, 2.0, 1.0]; a = [2.0, 1.0]
+            bb = b[:]
+            aa = a[:]
+            c = deconv(b,a)
+            @test c == [2.0, 0.0]
+            @test a == aa
+            @test b == bb
+        end
+    end
+end