Use Base._unsetindex! in pop! and popfirst!
#897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrobinson251
approved these changes
Feb 17, 2024
There was a problem hiding this comment.
Thanks, @kpamnany ! LGTM
@oxinabox are you still somewhat of a maintainer here? It'd be very helpful for us (at RAI) to get a new release with this fix 🙏 Or perhaps you could give me permissions on this repo? (I used to have them but never asked for them back when i lost all perms because of a MFA change) -- thanks, Frames!
|
@nickrobinson251 I am still maintaining things here, but I am happy to hand this one over to you. Usual procedure once happy with it: merge it into master, and backport it into |
|
Also i wonder if we could add a test for this? Something based on checking |
kpamnany
force-pushed
the
kp/fix-deque
branch
from
ab66207
to
00aa3ed
Compare
kpamnany
changed the title
Base._unsetindex! in pop! and popfirst! for DequeBase._unsetindex! in pop! and popfirst!
kpamnany
commented
Feb 20, 2024
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
kpamnany
force-pushed
the
kp/fix-deque
branch
2 times, most recently
from
c1ed503
to
d078d0d
Compare
kpamnany
force-pushed
the
kp/fix-deque
branch
2 times, most recently
from
6cadce7
to
856a86b
Compare
So that popped elements are not rooted by the deque and can be GCed when they drop out of caller scope.
So that popped elements are not rooted by the deque and can be GCed when they drop out of caller scope.
kpamnany
force-pushed
the
kp/fix-deque
branch
from
856a86b
to
d6b6d3c
Compare
nickrobinson251
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Bump codecov/codecov-action from 3 to 4 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Use `Base._unsetindex!` in `pop!` and `popfirst!` for Deque So that popped elements are not rooted by the deque and can be GCed when they drop out of caller scope. * Test Deque for leaks * Use `Base._unsetindex!` in `pop!` and `popfirst!` for CircularDeque So that popped elements are not rooted by the deque and can be GCed when they drop out of caller scope. * Test CircularDeque for leaks --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
nickrobinson251
added a commit
that referenced
this pull request
Feb 20, 2024
* Use `Base._unsetindex!` in `pop!` and `popfirst!` (#897) * Bump codecov/codecov-action from 3 to 4 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Use `Base._unsetindex!` in `pop!` and `popfirst!` for Deque So that popped elements are not rooted by the deque and can be GCed when they drop out of caller scope. * Test Deque for leaks * Use `Base._unsetindex!` in `pop!` and `popfirst!` for CircularDeque So that popped elements are not rooted by the deque and can be GCed when they drop out of caller scope. * Test CircularDeque for leaks --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump version * Make compatible with ancient Julia versions * fixup! Make compatible with ancient Julia versions * fixup! fixup! Make compatible with ancient Julia versions --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Kiran Pamnany <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
DequeandCircularDeque. So that popped elements are not rooted by the deque and can be GCed when they drop out of caller scope.Completes the fix of #884.