Merge pull request #904 from JamesWrigley/invalidations

Delete unnecessary methods to fix invalidations
JuliaCollections · Apr 12, 2024 · 3be0527 · 3be0527
2 parents a523186 + 82ace5b
commit 3be0527
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/src/accumulator.jl b/src/accumulator.jl
@@ -61,8 +61,6 @@ Base.setindex!(ct::Accumulator, x, v) = setindex!(ct.map, x, v)
 
 Base.haskey(ct::Accumulator, x) = haskey(ct.map, x)
 
-Base.keys(ct::Accumulator) = keys(ct.map)
-
 Base.values(ct::Accumulator) = values(ct.map)
 
 Base.sum(ct::Accumulator) = sum(values(ct.map))

diff --git a/src/circular_buffer.jl b/src/circular_buffer.jl
@@ -182,17 +182,13 @@ Return the number of elements currently in the buffer.
 """
 Base.length(cb::CircularBuffer) = cb.length
 
-Base.eltype(::Type{CircularBuffer{T}}) where T = T
-
 """
     size(cb::CircularBuffer)
 
 Return a tuple with the size of the buffer.
 """
 Base.size(cb::CircularBuffer) = (length(cb),)
 
-Base.convert(::Type{Array}, cb::CircularBuffer{T}) where {T} = T[x for x in cb]
-
 """
     isempty(cb::CircularBuffer)