Move CSS and JS scripts to template for create true overrides #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed scripts JS and CSS for add in tmpl/default.php
Added JS ans CSS files from mod_spsimpleportfolio.php so user can remove or change scripts from template override.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the pages must be fast, and better if it makes few requests to the server.
Loading embedded videos from youtube or vimeo on a website increases requests (approximately 11); so trying to reduce that I created an everride of the module, to eliminate the previews of the video, which was obtained as expected. But the module still continued to load the featherlight.min.js and featherlight.min.css files, when they were no longer needed, and the loading of those files could not be nulled because an override of the mod_spsimpleportfolio.php file cannot be created. Do the same if you want to switch to another preview script.
These changes that I am proposing solve that problem by giving better control over the files from the override.