Remove overly cautious checks in claimDomainFunds

JoinColony · Sep 26, 2024 · c978a65 · c978a65
1 parent 60923d4
commit c978a65
Showing 1 changed file with 17 additions and 11 deletions.
diff --git a/contracts/colonyNetwork/ColonyNetworkDeployer.sol b/contracts/colonyNetwork/ColonyNetworkDeployer.sol
@@ -270,20 +270,12 @@ contract ColonyNetworkDeployer is ColonyNetworkStorage {
     // when it was created via a cross-chain call (to an as-yet unwritten function).
     bytes32 salt = getColonyCreationSalt();
     // EtherRouter etherRouter = new EtherRouter();
-    EtherRouter etherRouter = EtherRouter(
-      payable(
-        ICreateX(CREATEX_ADDRESS).deployCreate3AndInit(
-          salt,
-          type(EtherRouterCreate3).creationCode,
-          abi.encodeWithSignature("setOwner(address)", (address(this))),
-          ICreateX.Values(0, 0)
-        )
-      )
-    );
+    address colonyAddress = deployEtherRouterViaCreateX(salt);
 
-    IColony colony = IColony(address(etherRouter));
+    IColony colony = IColony(colonyAddress);
 
     address resolverForColonyVersion = colonyVersionResolver[_version]; // ignore-swc-107
+    EtherRouter etherRouter = EtherRouter(payable(colonyAddress));
     etherRouter.setResolver(resolverForColonyVersion); // ignore-swc-113
 
     // Creating new instance of colony's authority
@@ -326,4 +318,18 @@ contract ColonyNetworkDeployer is ColonyNetworkStorage {
     DSAuth dsauth = DSAuth(_colonyAddress);
     dsauth.setOwner(address(0x0));
   }
+
+  function deployEtherRouterViaCreateX(bytes32 _salt) internal returns (address) {
+    EtherRouter etherRouter = EtherRouter(
+      payable(
+        ICreateX(CREATEX_ADDRESS).deployCreate3AndInit(
+          _salt,
+          type(EtherRouterCreate3).creationCode,
+          abi.encodeWithSignature("setOwner(address)", (address(this))),
+          ICreateX.Values(0, 0)
+        )
+      )
+    );
+    return address(etherRouter);
+  }
 }