Gv files provider waffle #212
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Glacer was deprecated in 2018
…e#10596) ## Purpose Adjust the serialization of embargo end dates in the registration API ## Changes Updated the get_embargo_end_date method to accurately retrieve embargo end dates from the root registration object. Co-authored-by: Uditi Mehta <[email protected]>
- Use MailChimp for onboarding Squashed commit of the following: commit 3a6a3b6 Author: Uditi Mehta <[email protected]> Date: Wed Apr 17 10:39:24 2024 -0400 Fixed incorrect mock assertion in test_confirm_email commit 6d4f1c0 Author: Uditi Mehta <[email protected]> Date: Wed Apr 17 10:18:52 2024 -0400 Updated tests to reflect the deactivation of welcome email commit 068ca8a Author: Uditi Mehta <[email protected]> Date: Wed Apr 17 09:53:14 2024 -0400 Remove unused import from views.py commit 5210f2b Author: Uditi Mehta <[email protected]> Date: Wed Apr 17 09:39:24 2024 -0400 ChangesDeactivated welcome email on user email confirmation commit 3d6c4ec Author: Uditi Mehta <[email protected]> Date: Fri Apr 12 16:24:20 2024 -0400 Updated the tests commit 14c123a Author: Uditi Mehta <[email protected]> Date: Fri Apr 12 15:18:37 2024 -0400 Removed the sending of 'Welcome to OSF' email to align with new onboarding process
Johnetordoff
force-pushed
the
gv-files-provider-waffle
branch
6 times, most recently
from
0b9d7f6
to
934ea23
Compare
… Interface (CenterForOpenScience#10608) ## Purpose Adding a boolean attribute to the AbstractProvider model. This change enables administrators to control whether a provider is displayed on the OSF Discover pages directly from the admin interface. ## Changes - Added advertiseOnDiscoverPage boolean field to AbstractProvider - Updated the admin forms and templates to include a checkbox for advertiseOnDiscoverPage - Adjusted the PreprintProviderDisplay view to serialize the new advertiseOnDiscoverPage field --------- Co-authored-by: Uditi Mehta <[email protected]>
Johnetordoff
force-pushed
the
gv-files-provider-waffle
branch
from
934ea23
to
a432dc1
Compare
…ce#10584) * refactor get_auth * conditionally get credentials and settings from GravyValet --------- Co-authored-by: John Tordoff <>
Johnetordoff
force-pushed
the
gv-files-provider-waffle
branch
7 times, most recently
from
293e89a
to
221248b
Compare
Johnetordoff
force-pushed
the
gv-files-provider-waffle
branch
from
221248b
to
d194c91
Compare
…ience#10613) * fix errors retrieving BaseFileNode and file path for metrics --------- Co-authored-by: John Tordoff <> Co-authored-by: Jon Walz <[email protected]>
into gv-files-provider-waffle * 'develop' of https://github.com/CenterForOpenScience/osf.io: [ENG-5140] #2 Update get_auth for GV and readability (CenterForOpenScience#10613)
Johnetordoff
force-pushed
the
gv-files-provider-waffle
branch
from
16853c7
to
375673b
Compare
Johnetordoff
force-pushed
the
gv-files-provider-waffle
branch
2 times, most recently
from
c7606c9
to
dc4cda4
Compare
into gv-files-provider-waffle * 'develop' of https://github.com/CenterForOpenScience/osf.io: Fix get auth number two (CenterForOpenScience#10614)
Johnetordoff
force-pushed
the
gv-files-provider-waffle
branch
2 times, most recently
from
ff1e20b
to
65ebf16
Compare
Johnetordoff
force-pushed
the
gv-files-provider-waffle
branch
from
65ebf16
to
e888e87
Compare
Johnetordoff
force-pushed
the
gv-files-provider-waffle
branch
from
a2a6176
to
9d1bbe5
Compare
Johnetordoff
force-pushed
the
gv-files-provider-waffle
branch
2 times, most recently
from
7a55c02
to
9f0d6e4
Compare
Johnetordoff
force-pushed
the
gv-files-provider-waffle
branch
7 times, most recently
from
647f35c
to
06cf8fe
Compare
Johnetordoff
force-pushed
the
gv-files-provider-waffle
branch
from
06cf8fe
to
9bd6ad5
Compare
check permissions appropriately for DraftRegistrations
Use DraftNode as source for files, only check DraftRegistration for permissions
into gv-files-provider-waffle * 'develop' of https://github.com/CenterForOpenScience/osf.io: add DraftRegistration file permission test (CenterForOpenScience#10626) add DraftRegistration file permission test (CenterForOpenScience#10622)
--------- Co-authored-by: Jon Walz <[email protected]>
into gv-files-provider-waffle * 'develop' of https://github.com/CenterForOpenScience/osf.io: Configurable GV Mock + HMAC Auth (CenterForOpenScience#10623)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Allows us to feature flip between our current system and the new GravyValet addon service. Should change
filesrelated routes to use new set up.Changes
get_addonfunctions for AbstractNode and OsfUser waffled to return mock configGravyValetAddonAppConfigto serve as addon proxy objectQA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket