[ENG-5430] GV get_addon feature flipping #211
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
force-pushed
the
gv-files-api-endpoint
branch
from
f43f30c
to
73cc7f2
Compare
Johnetordoff
changed the title
…penScience/osf.io into gv-files-api-endpoint * 'gv-files-api-endpoint' of https://github.com/CenterForOpenScience/osf.io: WIP format kwargs # Conflicts: # addons/box/models.py # osf/models/mixins.py
jwalz
reviewed
Apr 30, 2024
addons/box/models.py
Outdated
| for key, value in data_from_gv['user_settings'].items(): | ||
| setattr(settings_obj, key, value) | ||
|
|
||
| settings_obj.save() |
There was a problem hiding this comment.
no need to save, but do call full_clean to ensure everything is valid
osf/models/mixins.py
Outdated
|
|
||
| if waffle.flag_is_active(request, features.ENABLE_GV): | ||
| resp = requests.get( | ||
| f'{settings.DOMAIN}v1/resource-references/{self.uri}/authorized_storage_accounts/' |
There was a problem hiding this comment.
To get all configured storage addons for a node (two calls):
v1/resource_references/?filter[resource_uri]={self.uri}
->data[0][relationships][configured_storage_addons][links][self]
To get details on a specific configured addon (name == id)
v1/configured-storage-addons/{name}/
addons/box/models.py
Outdated
| settings_obj = UserSettings.objects.get(owner=owner) | ||
| except ObjectDoesNotExist: | ||
| return None # or handle the case where the settings object does not exist | ||
| settings_obj = UserSettings.objects.get_or_create(owner=owner) |
There was a problem hiding this comment.
drive by: this belongs in NodeSettings, the UserSettings rarely contain anything consequential for us (pretty much just a super janky dict mapping nodes to external accounts that we've replaced with actual database relationships on the gv side)
Johnetordoff
force-pushed
the
gv-files-api-endpoint
branch
2 times, most recently
from
b552211
to
401d8c9
Compare
Johnetordoff
force-pushed
the
gv-files-api-endpoint
branch
10 times, most recently
from
38dfed4
to
5fdb5b7
Compare
Johnetordoff
force-pushed
the
gv-files-api-endpoint
branch
2 times, most recently
from
541a161
to
ba28a9e
Compare
Johnetordoff
force-pushed
the
gv-files-api-endpoint
branch
4 times, most recently
from
606604c
to
37b3d86
Compare
Johnetordoff
force-pushed
the
gv-files-api-endpoint
branch
from
37b3d86
to
5768286
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Allows OSF legacy features to sync with GV addon system.
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-5430