Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming Changes #36

Merged
merged 5 commits into from
May 31, 2024
Merged

Renaming Changes #36

merged 5 commits into from
May 31, 2024

Conversation

ryanlevy
Copy link
Collaborator

@ryanlevy ryanlevy commented May 31, 2024 •
edited
Loading

This PR will do 4 things:

  • Rename some internal variables so that we never overload the function dimension
    • This includes an API change that functions like exp_itn(s; dimension=2) -> exp_itn(s; dim=2)
  • Rename calculate_fxyz and calculate_fx to just evaluate and not differentiate between 1d and multi-d (Suggested by @emstoudenmire )
  • Rename calculate_x and calculate_xyz to calculate_p
  • Rename/merge delta_x and delta_xyz to delta_p

@ryanlevy ryanlevy requested a review from JoeyT1994 May 31, 2024 16:45
JoeyT1994
JoeyT1994 reviewed May 31, 2024
View reviewed changes
Copy link
Owner

@JoeyT1994 JoeyT1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! (Other than reinstating the function I commented on above)

src/indexmap.jl Show resolved Hide resolved
JoeyT1994
JoeyT1994 approved these changes May 31, 2024
View reviewed changes
Copy link
Owner

@JoeyT1994 JoeyT1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Always appreciate a good cleanup of naming conventions.

@JoeyT1994 JoeyT1994 merged commit fb4f0ee into main May 31, 2024
3 checks passed
@ryanlevy ryanlevy deleted the dimFix branch May 31, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeyT1994 JoeyT1994 JoeyT1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanlevy @JoeyT1994