Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes and new features #22

Merged
merged 15 commits into from
Apr 25, 2024
Merged

Small fixes and new features #22

merged 15 commits into from
Apr 25, 2024

Conversation

ryanlevy
Copy link
Collaborator

@ryanlevy ryanlevy commented Apr 23, 2024

  • Fix identity operator and add some docs (we need a lot more...)
  • Beginning of a way to override BCs, should use a similar system like the sites system but we can deal with that later
  • Add more of the needed definitions of Digit sites, which allows for product states
  • include delta_x and delta_xyz to create a product state bit string configuration

@ryanlevy ryanlevy changed the title Small Fixes Small fixes and new features Apr 24, 2024
src/elementary_operators.jl Outdated Show resolved Hide resolved
src/elementary_operators.jl Outdated Show resolved Hide resolved
src/elementary_operators.jl Outdated Show resolved Hide resolved
@@ -155,6 +165,7 @@ function stencil(
truncate_op=true,
kwargs...,
)
# shifts = [ x+2Δh, x+Δh, x, x-Δh, x-2Δh]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Worth commenting this in as its not very straightforward.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(It should move to the doc string eventually too)

src/elementary_operators.jl Outdated Show resolved Hide resolved
src/elementary_operators.jl Outdated Show resolved Hide resolved
src/elementary_operators.jl Outdated Show resolved Hide resolved
@ryanlevy
Copy link
Collaborator Author

  • From discussion: swap left,right boundary to tuple and include default of size 1 to exand

@JoeyT1994
Copy link
Owner

Can you add a compat entry for Graphs.jl to this PR too (v1.8)? Just so we can register the package post this PR

@ryanlevy ryanlevy requested a review from JoeyT1994 April 25, 2024 11:50
@JoeyT1994
Copy link
Owner

Looks good to me! Do you want me to merge now and do the implement boundary conditions via a Tuple point above in a separate PR or do it in this PR? Up to you.

@ryanlevy
Copy link
Collaborator Author

Thanks! Lets do that in a different PR and plan out how we want the interface to look, I think it might get a bit messy if we want to allow full heterogeneous conditions

Copy link
Owner

@JoeyT1994 JoeyT1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge.

@JoeyT1994 JoeyT1994 merged commit bbdec04 into main Apr 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants