feat(network): add DNS fallback (truncated) PacketProxy #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
requested changes
Jun 27, 2023
jyyi1
added a commit
that referenced
this pull request
Jul 19, 2023
This PR introduces a network stack neutral `network.PacketProxy` that can be used to **relay** (e.g. a UDP proxy server) or **process** (e.g. a local DNS server) UDP packets. It is more efficient than the `transport.PacketListener` when you try to implement a local UDP server that can process UDP requests and get the responses without going to the internet (see #26 ).
fortuna
requested changes
Jul 19, 2023
network/dnstruncate/packet_proxy.go
Outdated
| if !h.closed.CompareAndSwap(false, true) { | ||
| return network.ErrClosed | ||
| } | ||
| h.respWriter.Close() // TODO(junyi): potential inf loop (rw.Close -> req.Close -> rw.Close ...) |
There was a problem hiding this comment.
Did you figure out the loop?
There was a problem hiding this comment.
there is no problem for this (because I've checked closed), but I will create another one with both the fix and a reproducing test case.
There was a problem hiding this comment.
I still see the TODO there
There was a problem hiding this comment.
added a reproducing test in #30 , will fix the potential issue in that pr.
jyyi1
commented
Jul 19, 2023
fortuna
requested changes
Jul 21, 2023
network/dnstruncate/packet_proxy.go
Outdated
| if !h.closed.CompareAndSwap(false, true) { | ||
| return network.ErrClosed | ||
| } | ||
| h.respWriter.Close() // TODO(junyi): potential inf loop (rw.Close -> req.Close -> rw.Close ...) |
There was a problem hiding this comment.
I still see the TODO there
Co-authored-by: Vinicius Fortuna <[email protected]>
jyyi1
changed the title
fortuna
approved these changes
Jul 21, 2023
Co-authored-by: Vinicius Fortuna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
dnstruncated.NewPacketProxy()to the SDK. This type can be used when the remote Shadowsocks server doesn't support UDP traffic at all. By using thisPacketProxy, we will always set theTC(truncated) bit in the DNS responses for all UDP DNS requests. So a well-implemented DNS client (e.g. the browser, thedigcommand) should retry the same DNS request over TCP.Related PR: #24 , #27