fix(test): wrong url used in expired certificate test #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
requested changes
May 29, 2024
| sd, err := NewStreamDialer(&transport.TCPDialer{}) | ||
| require.NoError(t, err) | ||
| _, err = sd.DialStream(context.Background(), "revoked.badssl.com:443") |
There was a problem hiding this comment.
I explicitly wanted to test for revoked here. I don't think the issue is with the original test. It seems like revoked.badssl.com no longer serves an expired cert, so we don't return an error. Chrome is considering it safe.
Can you instead comment it out or use t.Skip("Skipping until revoked.badssl.com is fixed") in addition to adding the expired test?
There was a problem hiding this comment.
As discussed offline, will keep the revoke test, but skip two platforms that won't throw errors.
fortuna
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TestRevokedshould beTestExpiredbecause the reasonx509.ExpiredinCertificateInvalidErrorstands for an expired certificate.Revoked certificate test is tricky, because it relies on the OS implementation (e.g., macOS, Windows), the error is weakly typed and different OS will report different error messages. For now the revocation test case for Linux and Windows are skipped because the certificate revocation list is not up-to-date on these two platforms.
The failing CI is blocking all PRs including #203, #226, and #241 .