This repository has been archived by the owner on May 6, 2024. It is now read-only.
fix: 💊 re-export APIs used by Outline Client #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outline Client is referencing the following APIs (Android JNI interface as an example) exported by
gomobile.But due to the recent refactoring, we introduced types that are not recognized by
gomobile. This is the only function exported inmasterbranch now:In this PR, I re-exported these functions (together with the new
NewClientFromJSON) by using the built-in types. Here is the exported Android JNI interface:/cc @sbruens , although the required APIs are re-exported, some of the data types still need to be updated:
OutlineTunnel->TunnelTun2socksOutlineTunnel->Tun2socksTunnelRelated PR: #118