Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment: transparent #595

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Experiment: transparent #595

wants to merge 22 commits into from

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Feb 14, 2024

Trying to use the transparent compiler in Rider.

@nojaf nojaf force-pushed the experiment/transparent-compiler branch from 7303448 to 30872e7 Compare February 14, 2024 15:41
@nojaf
Copy link
Contributor Author

nojaf commented Feb 14, 2024

To start somewhere I would start by using the new FSharpSnapshotProject and use the new API.
When FSharpChecker.Create(useTransparentCompiler = false) is should just call the old methods anyway: https://github.com/dotnet/fsharp/blob/02d11c67bf156bb406c127d3a552352f8696927a/src/Compiler/Service/BackgroundCompiler.fs#L1631-L1646

We will need to check of course if that is always the case.

@nojaf nojaf force-pushed the experiment/transparent-compiler branch from 2f8266c to cb06d6f Compare February 15, 2024 13:37
@nojaf nojaf force-pushed the experiment/transparent-compiler branch from 7c2a777 to 765c66e Compare February 22, 2024 15:42
@nojaf nojaf changed the base branch from dev to main February 22, 2024 15:42
nojaf added 20 commits March 11, 2024 12:21
@nojaf
After call
ee9edec
@nojaf
Use new API for ParseAndCheckDocument
f1ad0db
@nojaf
Use local JFCS
12bf829
@nojaf
FcsProjectBuilder with Snapshot
5dfc515
@nojaf
Use snapshot in FcsProjectProvider
09c897f
@nojaf
More WIP, try and use snapshot for script stuff.
902d778
@nojaf
Buildable solution
6ba5ba2
@nojaf
I was able to open Rider with this
5de1edb
@nojaf
Use TryGetRecentCheckResultsForFile
ae1089a
@nojaf
Restore TestDump
eee2df9
@nojaf
Reuse some more added APIs.
17999f2
@nojaf
Use GetProjectSnapshotFromScript
60b7fe6
@nojaf
This happens internally now.
f0f4a19
@nojaf
Filter psi source files on F#.
b2219d7
@nojaf
Add StandaloneDocument and use cookie when getting text.
0df8700
@nojaf
Only use FileModificationTimeUtc when the file exists.
375c774
@nojaf
Use FullPath as name.
a61e8ba
@nojaf
Thanks Alex!
e22fbfa
@nojaf
options.ReferencesOnDisk are not part of options.OtherOptions.
fd321d8
@nojaf
Did you know that file order matters in F#?
7e02460
@nojaf nojaf force-pushed the experiment/transparent-compiler branch from e8245d1 to 7e02460 Compare March 11, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nojaf