Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuickFix for ValueNotContainedMutabilityLiteralConstantValuesDiffer #546

Draft
wants to merge 25 commits into
base: net233
Choose a base branch
from
Draft

QuickFix for ValueNotContainedMutabilityLiteralConstantValuesDiffer #546

wants to merge 25 commits into from

Commits on Aug 22, 2023

  1. Quickfix for difference in mutability in signature file.

    @nojaf @dawedawe
    nojaf authored and dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    b5f622a View commit details
    Browse the repository at this point in the history

  2. Update error message in the ID.

    @nojaf @dawedawe
    nojaf authored and dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    676ef15 View commit details
    Browse the repository at this point in the history

  3. Start working on quickfix for ValueNotContainedMutabilityLiteralConst… 

    …antValuesDiffer
    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    3e7d62e View commit details
    Browse the repository at this point in the history

  4. rename 

    update signature, not impl
    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    b94f311 View commit details
    Browse the repository at this point in the history

  5. refactor

    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    243dc20 View commit details
    Browse the repository at this point in the history

  6. update type in signature file if needed

    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9c36e72 View commit details
    Browse the repository at this point in the history

  7. add test case with inline comments

    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    d6b0b5e View commit details
    Browse the repository at this point in the history

  8. rename error to LiteralConstantValuesDifferError, no need to use the … 

    …exact same name as in FSComp.txt
    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    3139293 View commit details
    Browse the repository at this point in the history

  9. format changes

    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    1cd7b7c View commit details
    Browse the repository at this point in the history

  10. check if type of impl can be resolved in sig before making fix available

    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    215b53a View commit details
    Browse the repository at this point in the history

  11. - handle Literals with other Literals as their expression 

    - handle symbol availability from opened modules
    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    38dd977 View commit details
    Browse the repository at this point in the history

  12. add test for complex expressions fom lang preview

    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    c2461c2 View commit details
    Browse the repository at this point in the history

  13. improve naming of tests

    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    12c4470 View commit details
    Browse the repository at this point in the history

  14. add overload of ResolveWithFcs that takes a context node

    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    eb494d3 View commit details
    Browse the repository at this point in the history

  15. add test with parens in the pattern

    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    cf75f65 View commit details
    Browse the repository at this point in the history

  16. - improve naming 

    - refactor to use ResolveWithFcs()
- support patterns with parens
    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    3b96855 View commit details
    Browse the repository at this point in the history

  17. Add validation of binary expressions

    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    119aca3 View commit details
    Browse the repository at this point in the history

  18. the FCS error can also mean that the impl side lacks the Literal attr… 

    …ibute
    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    e8d43c8 View commit details
    Browse the repository at this point in the history

  19. - use IgnoreInnerParens() 

    - pass opName to ResolveWithFcs
- pass true as resolveExpr to ResolveWithFcs
- pass true as qualified to ResolveWithFcs
    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    4cf1127 View commit details
    Browse the repository at this point in the history

  20. tighten match of expression

    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    fc3f30a View commit details
    Browse the repository at this point in the history

  21. rename "UpdateLiteralConstantFix" to "UpdateLiteralConstantInSignatur… 

    …eFix"

rename folder of test files
    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9b12f36 View commit details
    Browse the repository at this point in the history

  22. rename error from "LiteralConstantValuesDiffer" to "LiteralConstantVa… 

    …luesDifferInSignature"
    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    71d8675 View commit details
    Browse the repository at this point in the history

  23. for the time being, don't offer the fix for measure constants

    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    18b5e8c View commit details
    Browse the repository at this point in the history

  24. Support validation checks for Constants with units of measure types

    @dawedawe
    dawedawe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    35a4825 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Don't update the return type for UoM as FSharpType.Format is currentl… 

    …y broken for UoM
    @dawedawe
    dawedawe committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    884e2a6 View commit details
    Browse the repository at this point in the history