Signature tweak to the grammar. #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
force-pushed
the
signature-parser-grammar
branch
from
a7883b5
to
05c0e5b
Compare
auduchinok
reviewed
May 8, 2023
| INestedModuleDeclaration CreateNestedModule(string name); | ||
|
|
||
| IModuleMember CreateModuleMember(string source); | ||
| IFSharpTypeMemberDeclaration CreateTypeMemberSignature(string source); |
There was a problem hiding this comment.
It seems it can also be used to create non-signature type members? If true, then maybe something like CreateTypeMember would be a better name.
auduchinok
reviewed
May 8, 2023
Comment on lines
+31
to
+33
| if memberSigs.IsEmpty then | ||
| x.AdvanceToTokenOrRangeEnd(FSharpTokenType.END, parentRange) | ||
| x.Advance() |
There was a problem hiding this comment.
Could you add a parser test and/or a comment about the pending FCS fix for this, please?
There was a problem hiding this comment.
Hmm, I added a test but the problem is still there.
If there is nothing besides an empty nested module the parentRange will end right before the = token.
|
@nojaf Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted the grammar and parser changes from #481