Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inferred type name hints #118

Open
wants to merge 58 commits into
base: net211
Choose a base branch
from
Open

Add inferred type name hints #118

wants to merge 58 commits into from

Conversation

saul
Copy link
Contributor

@saul saul commented Apr 29, 2020 •
edited
Loading

image

Todo:

  • Hook into various the Parameter Name Hints > Type Name Hints settings

saul and others added 30 commits March 30, 2020 09:15
@saul
Update InferredTypeCodeVisionProvider.fs
ea0c37b
@saul
Split into PipeChainCodeVisionProvider
cef15fa
@saul
Create Multi line.fs.gold
c60867a
@saul
Hook into the tooltip for the |> operator
73c12bb
@saul
Update Multi line.fs.gold
ff0b40c
@saul
Add TypeHintsAdornmentProvider
88520c1
@saul
Update TypeHintsAdornmentProvider.fs
c12814b
@saul
Update TypeHintsAdornmentProvider.fs
b224f68
@saul
Markups
9521a2e
@saul
Update TypeHintsAdornmentProvider.fs
d67e92c
@saul
Add more tests
61d3ef3
@saul
Add new lines
69145e5
@saul
Add setting
1fa07ac
@saul
Update TypeHintAdornmentStage.fs
37465f6
@saul
Add option to 'Hide when |> is on same line as argument'
cc23ca5
@saul
Invalidate highlighting on type hint setting change
89808fe
@saul
Update TypeHintAdornmentStage.fs
6a33f80
@saul
Update TypeHintAdornmentStage.fs
0418681
@saul
Use {HideSameLine:All} in tests
6c03c7c
@saul
Add InferredTypeHintHighlightingProcess
2312f7b
@saul
Reorganisation
be94166
@saul
Delete ReSharper.FSharp.sln.DotSettings.user
a718242
@saul
Merge branch 'net201-pipe-chain-insight' into net201-local-ref-pat-hints
1b7ab5c
@saul
Add tests
1e49dea
@saul
Put && on end of life
7647371
@saul
Code style
6e15e68
@saul
Merge branch 'net201-pipe-chain-insight' into net201-local-ref-pat-hints
cf32c8f
@saul
Update InferredTypeHintStage.fs
d2ab70e
@saul
More code style changes
778d7d1
@saul
Merge branch 'net201-pipe-chain-insight' into net201-local-ref-pat-hints
780727d
@saul
Copy link
Contributor Author

saul commented May 23, 2020

This is ready for review now :)

auduchinok
auduchinok requested changes May 25, 2020
View reviewed changes
Copy link
Collaborator

@auduchinok auduchinok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here're a few nits and a request to check for null checks in the tree visitor. The rest looks good to me!

ReSharper.FSharp/src/FSharp.Psi.Features/src/Daemon/Stages/InferredTypeHintStage.fs Outdated Show resolved Hide resolved
ReSharper.FSharp/src/FSharp.Psi.Features/src/Daemon/Stages/InferredTypeHintStage.fs Outdated Show resolved Hide resolved
ReSharper.FSharp/src/FSharp.Psi.Features/src/Daemon/Stages/InferredTypeHintStage.fs Outdated Show resolved Hide resolved
ReSharper.FSharp/src/FSharp.Psi.Features/src/Daemon/Stages/InferredTypeHintStage.fs Outdated Show resolved Hide resolved
@auduchinok
Copy link
Collaborator

@saul I've fixed the remaining tests. For some reason turning these hints off doesn't work for me, could you take a look?

@drhumlen
Copy link

drhumlen commented Jul 3, 2020

Bump @saul : us F#ers need this feature! 😄

@drhumlen
Copy link

@saul @auduchinok : Where are we on this feature?

@saul
Merge remote-tracking branch 'upstream/net203' into net201-local-ref-…
85c88a8 
…pat-hints

# Conflicts:
#	ReSharper.FSharp/src/FSharp.Common/src/Settings/FSharpOptions.fs
@saul
API changes
9ff226e
@saul saul changed the base branch from net202 to net203 September 30, 2020 20:22
@saul
Copy link
Contributor Author

saul commented Sep 30, 2020

Rebased onto net203, tests working and tested manually. This should be good to go @auduchinok :)

@En3Tho
Copy link
Contributor

En3Tho commented Jan 3, 2021

@auduchinok @saul Can this be reviewed please? Looks very neat :)

@drhumlen
Copy link

drhumlen commented Jan 5, 2021

Especially now with ctrl to toggle inline hints. Inline hints arent as intrusive as before since you only see them when needed.

@En3Tho
Copy link
Contributor

En3Tho commented Jan 5, 2021

@drhumlen Exactly! I would like to put inline signatures to toggle behaviour too. This way we could have very clean code with help only when needed

@auduchinok auduchinok changed the base branch from net203 to net211 January 27, 2021 16:57
@En3Tho
Copy link
Contributor

En3Tho commented Mar 15, 2021

@saul @auduchinok Hey! Can we do something to make this feature green and merged?

@auduchinok
Copy link
Collaborator

@En3Tho Yes, will soon look into it.

@Stephan-C Stephan-C mentioned this pull request Nov 23, 2021
Closed
@nathanpovo
Copy link

Are there any updates on this? This PR has been open for 3 years.

Is there something that the rest of the community can do to get this merged?

@auduchinok
Copy link
Collaborator

@nathanpovo Thanks for writing about it! We're planning to pick it up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auduchinok auduchinok auduchinok requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saul @drhumlen @auduchinok @En3Tho @nathanpovo