Throw runtime_error in SimpleSocketSender instead of dummy socket for…

… non-TCP protocol.
JetBrains · Jan 3, 2024 · 50bc047 · 50bc047
1 parent e43442d
commit 50bc047
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/rd-cpp/thirdparty/clsocket/src/SimpleSocketSender.h b/rd-cpp/thirdparty/clsocket/src/SimpleSocketSender.h
@@ -13,10 +13,9 @@ class CSimpleSocketSender
 public:
     explicit CSimpleSocketSender(const std::shared_ptr<CSimpleSocket>& socket) : m_error(CSimpleSocket::SocketSuccess)
     {
-        if (socket->m_nSocketType == CSimpleSocket::CSocketType::SocketTypeTcp)
-            m_socket = socket;
-        else
-            m_socket = std::make_shared<CSimpleSocket>();
+        if (socket->m_nSocketType != CSimpleSocket::CSocketType::SocketTypeTcp)
+        	throw std::runtime_error("Only TCP sockets are supported");
+		m_socket = socket;
     }
 
     int32_t Send(const uint8_t* pBuf, size_t bytesToSend) const;

diff --git a/rd-cpp/thirdparty/clsocket/src/StatTimer.h b/rd-cpp/thirdparty/clsocket/src/StatTimer.h
@@ -62,8 +62,6 @@
 
 #include "Host.h"
 
-#include <algorithm>
-
 #if defined(_WIN32)
   #define GET_CLOCK_COUNT(x) QueryPerformanceCounter((LARGE_INTEGER *)x)
 #else