fix: Fix name casing inspection

JetBrains · May 31, 2023 · 1283832 · 1283832
1 parent 11ca017
commit 1283832
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@
 - Fixed file icon missing if all tests has property calls
 - Fixed gutter icon not updating state correctly
 - Fixed test names with `[` and `]` not being matched correctly
+- Fixed test name casing inspection not working correctly with `it` tests
 
 ## 1.9.2 - 2023-03-01
 

diff --git a/gradle.properties b/gradle.properties
@@ -3,7 +3,7 @@
 
 pluginGroup = com.pestphp
 pluginName = PEST PHP
-pluginVersion = 1.9.3-EAP.2
+pluginVersion = 1.9.3
 
 # See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
 # for insight into build numbers and IntelliJ Platform versions.

diff --git a/src/main/kotlin/com/pestphp/pest/inspections/InvalidTestNameCaseInspection.kt b/src/main/kotlin/com/pestphp/pest/inspections/InvalidTestNameCaseInspection.kt
@@ -22,7 +22,12 @@ class InvalidTestNameCaseInspection : PhpInspection() {
                 file.getPestTests()
                     .groupBy { it.getPestTestName() }
                     .filterKeys { it != null }
-                    .filterKeys { !it!!.contains(' ') }
+                    .filterKeys {
+                        // Remove `it ` prefix from test names
+                        val testName = if (it!!.startsWith("it ")) it.substring(3) else it
+
+                        !testName.contains(' ')
+                    }
                     .filterKeys { it!!.splitToWords().joinToString(" ") != it }
                     .forEach {
                         declareProblemType(holder, it.value)

diff --git a/src/test/resources/com/pestphp/pest/inspections/InvalidTestNameCase.after.php b/src/test/resources/com/pestphp/pest/inspections/InvalidTestNameCase.after.php
@@ -3,3 +3,7 @@
 test('basic test', function () {
     $this->assertTrue(true);
 });
+
+it('is basic test', function () {
+    $this->assertTrue(true);
+});
diff --git a/src/test/resources/com/pestphp/pest/inspections/InvalidTestNameCase.php b/src/test/resources/com/pestphp/pest/inspections/InvalidTestNameCase.php
@@ -3,3 +3,7 @@
 test(<weak_warning descr="Pest test names words must be space separated.">'basic_test'</weak_warning>, function () {
     $this->assertTrue(true);
 });
+
+it(<weak_warning descr="Pest test names words must be space separated.">'is_basic_test'</weak_warning>, function () {
+    $this->assertTrue(true);
+});