Fixed issue #1778 by removing a hash of the absolute artifact path appended to the end of the version string. That hash made artifact version different on different PCs and also breaks Gradle dependency locking. #1780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
See comment #1778 (comment) on what this PR improves. Also in the description of #1778 there is a list of reasons why that hash is bad.
Two major points are:
An attempt to fix the issue. I am not really sure why that hash was added initially, but everything seems to work without it. It fixes #1778 but it did not fix #1779 unfortunately.
Please have a look at the new tests which I've added. The ones which are ignored are still broken due to #1779.
The non-ignored tests actually were passing even before the fix & still passing after. I tried a lot of things, but for some reason I could not reproduce it in tests (probably the build classpath is too small there and locks do not make a difference). See #1778 (comment) for context. It is reproducible here https://github.com/AlexanderBartash/intellij-platform-plugin-template/tree/dep-lock-bug and this fix helps to fix dependency locking (this issue), but does not fix dependency verification #1779
Description
In the issue.
Related Issue
#1778
Motivation and Context
#1778
How Has This Been Tested
Integration tests.
Types of changes
Checklist