Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gradle configuration cache warnings in JarSearchableOptionsTask & PrepareJarSearchableOptionsTask #1771

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

AlexanderBartash
Copy link
Contributor

Pull Request Details

Fix Gradle configuration cache warnings in JarSearchableOptionsTask & PrepareJarSearchableOptionsTask caused by lazy value calculation, which uses a task reference. It has been fixed by moving out the value of Task.enabled into a property and explicitly defining it as a task input. Also added explicit dependencies between buildSearchableOptions -> prepareJarSearchableOptions -> jarSearchableOptions.

Description

Self-explanatory above.

Related Issue

No ticket. Can be reproduced by "./gradlew buildPlugin" with

intellijPlatform {
    buildSearchableOptions = providers.gradleProperty("org.jetbrains.intellij.platform.buildSearchableOptions").map {
        it.toBoolean()
    }

image

Motivation and Context

How Has This Been Tested

Integration tests.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ x] I have read the CONTRIBUTING document.
  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have included my change in the CHANGELOG.
  • [ x] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

@AlexanderBartash AlexanderBartash force-pushed the searchable-optionc-conf-cache branch 2 times, most recently from e497994 to af5e5d1 Compare September 24, 2024 18:59
… PrepareJarSearchableOptionsTask caused by lazy value calculation, which uses a task reference. It has been fixed by moving out the value of Task.enabled into a property and explicitly defining it as a task input. Also added explicit dependencies between buildSearchableOptions -> prepareJarSearchableOptions -> jarSearchableOptions.
@AlexanderBartash
Copy link
Contributor Author

Since it was also fixed in 4633113 I removed all code and left only tests.

@hsz
Copy link
Member

hsz commented Sep 24, 2024

Thank you!

@hsz hsz merged commit 976c587 into JetBrains:main Sep 24, 2024
@AlexanderBartash AlexanderBartash deleted the searchable-optionc-conf-cache branch September 27, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants