Skip to content

Commit

Permalink
Remove legacy_import metrics
Browse files Browse the repository at this point in the history
  • Loading branch information
annaMarchenkoJetBrains committed Sep 6, 2024
1 parent c0f812c commit ff56c47
Show file tree
Hide file tree
Showing 3 changed files with 113 additions and 129 deletions.
4 changes: 0 additions & 4 deletions cmd/benchmark/clickhouse_perf_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ func TestClickhouse(_ *testing.T) {
"importer_run.org.jetbrains.idea.maven.importing.MavenExternalAnnotationsConfigurator.total_duration_ms",
"importer_run.org.jetbrains.idea.maven.importing.MavenRemoteRepositoriesConfigurator.total_duration_ms",
"importer_run.org.jetbrains.kotlin.idea.maven.KotlinMavenImporter.total_duration_ms",
"legacy_import.create_modules.duration_ms",
"legacy_import.delete_obsolete.duration_ms",
"legacy_import.duration_ms",
"legacy_import.importers.duration_ms",
"workspace_commit.attempts",
"workspace_commit.duration_in_background_ms",
"workspace_commit.duration_in_write_action_ms",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,6 @@ export const MAVEN_METRICS_DASHBOARD = [
"workspace_import.legacy_importers.stats.duration_of_bridges_creation_ms",
"workspace_import.legacy_importers.stats.duration_of_bridges_commit_ms",
"workspace_import.populate.duration_ms",

// Legacy import
"legacy_import.create_modules.duration_ms",
"legacy_import.delete_obsolete.duration_ms",
"legacy_import.duration_ms",
"legacy_import.importers.duration_ms",
]

const importerRunMetricTypes = ["total_duration_ms", "number_of_modules"]
Expand Down
232 changes: 113 additions & 119 deletions pkg/degradation-detector/setting/mavenSettings.go
Original file line number Diff line number Diff line change
@@ -1,145 +1,139 @@
package setting

import (
detector "github.com/JetBrains/ij-perf-report-aggregator/pkg/degradation-detector"
"slices"
detector "github.com/JetBrains/ij-perf-report-aggregator/pkg/degradation-detector"
"slices"
)

func getMavenTests() []string {
return []string{
"project-import-maven-quarkus",
"project-reimport-maven-quarkus",
"project-import-from-cache-maven-quarkus",
"project-import-maven-1000-modules",
"project-import-maven-5000-modules",
"project-import-maven-keycloak",
"project-import-maven-javaee7",
"project-import-maven-javaee8",
"project-import-maven-jersey",
"project-import-maven-flink",
"project-import-maven-drill",
"project-import-maven-azure-sdk-java",
"project-import-maven-hive",
"project-import-maven-quarkus-to-legacy-model",
"project-import-maven-1000-modules-to-legacy-model",
}
return []string{
"project-import-maven-quarkus",
"project-reimport-maven-quarkus",
"project-import-from-cache-maven-quarkus",
"project-import-maven-1000-modules",
"project-import-maven-5000-modules",
"project-import-maven-keycloak",
"project-import-maven-javaee7",
"project-import-maven-javaee8",
"project-import-maven-jersey",
"project-import-maven-flink",
"project-import-maven-drill",
"project-import-maven-azure-sdk-java",
"project-import-maven-hive",
"project-import-maven-quarkus-to-legacy-model",
"project-import-maven-1000-modules-to-legacy-model",
}
}

func getMavenMetrics() []string {
return []string{
// Main flow
"maven.sync.duration",
"maven.projects.processor.resolving.task",
"maven.projects.processor.reading.task",
"maven.import.stats.plugins.resolving.task",
"maven.import.stats.applying.model.task",
"maven.import.stats.sync.project.task",
"maven.import.after.import.configuration",
"maven.import.configure.post.process",
"maven.project.importer.base.refreshing.files.task",
"maven.project.importer.post.importing.task.marker",
"post_import_tasks_run.total_duration_ms",
return []string{
// Main flow
"maven.sync.duration",
"maven.projects.processor.resolving.task",
"maven.projects.processor.reading.task",
"maven.import.stats.plugins.resolving.task",
"maven.import.stats.applying.model.task",
"maven.import.stats.sync.project.task",
"maven.import.after.import.configuration",
"maven.import.configure.post.process",
"maven.project.importer.base.refreshing.files.task",
"maven.project.importer.post.importing.task.marker",
"post_import_tasks_run.total_duration_ms",

// Workspace commit
"workspace_commit.attempts",
"workspace_commit.duration_in_background_ms",
"workspace_commit.duration_in_write_action_ms",
"workspace_commit.duration_of_workspace_update_call_ms",
// Workspace commit
"workspace_commit.attempts",
"workspace_commit.duration_in_background_ms",
"workspace_commit.duration_in_write_action_ms",
"workspace_commit.duration_of_workspace_update_call_ms",

// Workspace import
"workspace_import.commit.duration_ms",
"workspace_import.duration_ms",
"workspace_import.legacy_importers.duration_ms",
"workspace_import.legacy_importers.stats.duration_of_bridges_creation_ms",
"workspace_import.legacy_importers.stats.duration_of_bridges_commit_ms",
"workspace_import.populate.duration_ms",
// Workspace import
"workspace_import.commit.duration_ms",
"workspace_import.duration_ms",
"workspace_import.legacy_importers.duration_ms",
"workspace_import.legacy_importers.stats.duration_of_bridges_creation_ms",
"workspace_import.legacy_importers.stats.duration_of_bridges_commit_ms",
"workspace_import.populate.duration_ms",

// Legacy import
"legacy_import.create_modules.duration_ms",
"legacy_import.delete_obsolete.duration_ms",
"legacy_import.duration_ms",
"legacy_import.importers.duration_ms",

// IDE/Java common metrics
"AWTEventQueue.dispatchTimeTotal",
"CPU | Load |Total % 95th pctl",
"Memory | IDE | RESIDENT SIZE (MB) 95th pctl",
"Memory | IDE | VIRTUAL SIZE (MB) 95th pctl",
"gcPause",
"gcPauseCount",
"fullGCPause",
"freedMemoryByGC",
"totalHeapUsedMax",
"JVM.GC.collectionTimesMs",
"JVM.GC.collections",
"JVM.maxHeapMegabytes",
"JVM.maxThreadCount",
"JVM.totalCpuTimeMs",
}
// IDE/Java common metrics
"AWTEventQueue.dispatchTimeTotal",
"CPU | Load |Total % 95th pctl",
"Memory | IDE | RESIDENT SIZE (MB) 95th pctl",
"Memory | IDE | VIRTUAL SIZE (MB) 95th pctl",
"gcPause",
"gcPauseCount",
"fullGCPause",
"freedMemoryByGC",
"totalHeapUsedMax",
"JVM.GC.collectionTimesMs",
"JVM.GC.collections",
"JVM.maxHeapMegabytes",
"JVM.maxThreadCount",
"JVM.totalCpuTimeMs",
}
}

func GenerateMavenSettings() []detector.PerformanceSettings {
return slices.Concat(
generateMavenSettingsOnInstaller(),
generateMavenSettingsOnFastInstaller(),
)
return slices.Concat(
generateMavenSettingsOnInstaller(),
generateMavenSettingsOnFastInstaller(),
)
}

func generateMavenSettingsOnInstaller() []detector.PerformanceSettings {
tests := make([]string, 0, len(getMavenTests()))
for _, test := range getMavenTests() {
tests = append(tests, test+"/measureStartup")
}
metrics := getMavenMetrics()
tests := make([]string, 0, len(getMavenTests()))
for _, test := range getMavenTests() {
tests = append(tests, test+"/measureStartup")
}
metrics := getMavenMetrics()

settings := make([]detector.PerformanceSettings, 0, 200)
for _, test := range tests {
for _, metric := range metrics {
settings = append(settings, detector.PerformanceSettings{
Db: "perfint",
Table: "idea",
Machine: "intellij-linux-hw-hetzner%",
Project: test,
Metric: metric,
Branch: "master",
SlackSettings: detector.SlackSettings{
Channel: "maven-perf-tests-notifications",
ProductLink: "intellij",
},
})
}
settings := make([]detector.PerformanceSettings, 0, 200)
for _, test := range tests {
for _, metric := range metrics {
settings = append(settings, detector.PerformanceSettings{
Db: "perfint",
Table: "idea",
Machine: "intellij-linux-hw-hetzner%",
Project: test,
Metric: metric,
Branch: "master",
SlackSettings: detector.SlackSettings{
Channel: "maven-perf-tests-notifications",
ProductLink: "intellij",
},
})
}

}
return settings
}
return settings
}

func generateMavenSettingsOnFastInstaller() []detector.PerformanceSettings {
tests := make([]string, 0, len(getMavenTests()))
for _, test := range getMavenTests() {
tests = append(tests, test+"/fastInstaller")
}
metrics := getMavenMetrics()
tests := make([]string, 0, len(getMavenTests()))
for _, test := range getMavenTests() {
tests = append(tests, test+"/fastInstaller")
}
metrics := getMavenMetrics()

settings := make([]detector.PerformanceSettings, 0, 200)
for _, test := range tests {
for _, metric := range metrics {
settings = append(settings, detector.PerformanceSettings{
Db: "perfintDev",
Table: "idea",
Machine: "intellij-linux-hw-hetzner%",
Project: test,
Metric: metric,
Branch: "master",
SlackSettings: detector.SlackSettings{
Channel: "maven-perf-tests-notifications",
ProductLink: "intellij",
},
AnalysisSettings: detector.AnalysisSettings{
MinimumSegmentLength: 10,
},
})
}
settings := make([]detector.PerformanceSettings, 0, 200)
for _, test := range tests {
for _, metric := range metrics {
settings = append(settings, detector.PerformanceSettings{
Db: "perfintDev",
Table: "idea",
Machine: "intellij-linux-hw-hetzner%",
Project: test,
Metric: metric,
Branch: "master",
SlackSettings: detector.SlackSettings{
Channel: "maven-perf-tests-notifications",
ProductLink: "intellij",
},
AnalysisSettings: detector.AnalysisSettings{
MinimumSegmentLength: 10,
},
})
}

}
return settings
}
return settings
}

0 comments on commit ff56c47

Please sign in to comment.