-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve usability of rez_pip as python library. #89
base: main
Are you sure you want to change the base?
Commits on Jan 12, 2024
-
refacto(cli): extract the main "_run" function to new module
by exposing this private function publicly, this improves usability of rez-pip as a python library and not simply a CLI. This also make it clear of what really are the input of the function. An improvement over the function argument name was also performed with a focus on explicity.
Configuration menu - View commit details
-
Copy full SHA for aa456b9 - Browse repository at this point
Copy the full SHA aa456b9View commit details -
refacto(main): set sensible defaults
- rezRelease: to False because to True would be the most "destructive" action, with the biggest consequences.
Configuration menu - View commit details
-
Copy full SHA for c11a086 - Browse repository at this point
Copy the full SHA c11a086View commit details -
refacto(main): extract new pip_install_packages function
reduce the size of the rez_install_pip_packages and allow for more re-usability as a python library
Configuration menu - View commit details
-
Copy full SHA for 9a76574 - Browse repository at this point
Copy the full SHA 9a76574View commit details -
refacto(main): use pathlib.Path when possible
make it more explicit that we are expecting path like object
Configuration menu - View commit details
-
Copy full SHA for 13b7ee4 - Browse repository at this point
Copy the full SHA 13b7ee4View commit details -
chore: fix tests following refacto of cli module
fix mentions of `rez.cli._run`
Configuration menu - View commit details
-
Copy full SHA for d41daba - Browse repository at this point
Copy the full SHA d41dabaView commit details -
feat(rez): return package created in createPackage
again in effort to make rez_pip more usable as a python library where its function could be re-used
Configuration menu - View commit details
-
Copy full SHA for 69964a9 - Browse repository at this point
Copy the full SHA 69964a9View commit details -
feat(main): return rez package created
again in effort to make rez_pip more usable as a python library where its function could be re-used
Configuration menu - View commit details
-
Copy full SHA for aa4b1b9 - Browse repository at this point
Copy the full SHA aa4b1b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e1244b - Browse repository at this point
Copy the full SHA 6e1244bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 134256c - Browse repository at this point
Copy the full SHA 134256cView commit details -
refacto(main): rename pipPackages parameter
to avoid confusion when the list[str] is converted to a list[PackageInfo] which trigger mypy
Configuration menu - View commit details
-
Copy full SHA for a970df4 - Browse repository at this point
Copy the full SHA a970df4View commit details -
Configuration menu - View commit details
-
Copy full SHA for de5cf17 - Browse repository at this point
Copy the full SHA de5cf17View commit details -
refacto(main): simplify pip_install_package
address issue introduced in 9a76574 where type were not as expected for the "list of pip packages"
Configuration menu - View commit details
-
Copy full SHA for 049c580 - Browse repository at this point
Copy the full SHA 049c580View commit details -
Configuration menu - View commit details
-
Copy full SHA for a30aed9 - Browse repository at this point
Copy the full SHA a30aed9View commit details -
refacto(main): simplify os.fspath call
as we are now using pathlib objects
Configuration menu - View commit details
-
Copy full SHA for a184ebf - Browse repository at this point
Copy the full SHA a184ebfView commit details -
refacto(main): revert back pip_install_packages function
is actually not that useful, let's keep smaller changes for now
Configuration menu - View commit details
-
Copy full SHA for 9c1bc97 - Browse repository at this point
Copy the full SHA 9c1bc97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 845e61f - Browse repository at this point
Copy the full SHA 845e61fView commit details -
feat(rez): add "rezPackageCreationCallback"
help at achieving specific override per rez package when using rez_pip as python library
Configuration menu - View commit details
-
Copy full SHA for f7b6519 - Browse repository at this point
Copy the full SHA f7b6519View commit details -
refacto(main): separate python executable lookup
the intention is to try to provide as low-level function as possible for a library-use This new function should also provide a workaround for JeanChristopheMorinPerso#46
Configuration menu - View commit details
-
Copy full SHA for 6c2cfb5 - Browse repository at this point
Copy the full SHA 6c2cfb5View commit details -
refacto(rez): remove "release" arg in creation callback
I have the feeling that the "release" parameter shouldn't part of the createPackage function, so to avoid an annoying refacto in the future that remove this arg, it is best to do it now. It is anyway easier to add arg to the callback than removing some.
Configuration menu - View commit details
-
Copy full SHA for 05a38fc - Browse repository at this point
Copy the full SHA 05a38fcView commit details
Commits on Jan 13, 2024
-
feat(rez): extract getPythonExecutable from getPythonExecutables
again in the effort to make it easier to use rez_pip as a python library
Configuration menu - View commit details
-
Copy full SHA for 94466f3 - Browse repository at this point
Copy the full SHA 94466f3View commit details -
feat(rez): extract findPythonPackages from getPythonExecutables
again in the effort to make it easier to use rez_pip as a python library
Configuration menu - View commit details
-
Copy full SHA for 3dc8b08 - Browse repository at this point
Copy the full SHA 3dc8b08View commit details