Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only return the latest version for major+minor python versions #83

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

JeanChristopheMorinPerso
Copy link
Owner

Fixes #82.

Only return the latest version for major+minor python versions instead of returning all versions. Returning all versions is useless in the vast majority of cases.

As a refresher, we need to install python packages for multiple python versions when the package is a python extension (contains compiled code) as explained in https://rez-pip.readthedocs.io/en/latest/faq.html#python-extensions-compiled.

Python extensions don't need to be re-compiled for every single major+minor+patch version of Python.

With this PR, if you have python 3.7.8, 3.7.9, 3.8.1, 3.8.4, 3.8.9 in your repository, running rez-pip numpy will result in numpy being installed for 3.7.9 and 3.8.9 instead of 3.7.8, 3.7.9, 3.8.1, 3.8.4, 3.8.9.

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a08993a) 80.67% compared to head (81e619c) 82.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   80.67%   82.17%   +1.50%     
==========================================
  Files           8        8              
  Lines         714      718       +4     
  Branches      126      149      +23     
==========================================
+ Hits          576      590      +14     
+ Misses        120      113       -7     
+ Partials       18       15       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeanChristopheMorinPerso JeanChristopheMorinPerso force-pushed the only_ingest_for_x.x branch 2 times, most recently from aca50b7 to 81e619c Compare December 16, 2023 19:26
…d of returning all versions. Returning all versions is useless in the vast majority of cases.

Signed-off-by: Jean-Christophe Morin <[email protected]>
@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit 3139c71 into main Dec 16, 2023
36 checks passed
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the only_ingest_for_x.x branch December 16, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installs for multiple pythons?
1 participant