fix(cli): add RuntimeError when no python package found #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this make it more explicit there is an issue somewhere instead of rez-pip just finishing without outputing anything to stdout
|
Note that all tests passed on my local Windows machine with python-3.10, note sure what is going on here. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
- Coverage 82.14% 81.91% -0.23%
==========================================
Files 8 8
Lines 717 719 +2
Branches 149 150 +1
==========================================
Hits 589 589
- Misses 113 115 +2
Partials 15 15 ☔ View full report in Codecov by Sentry. |
JeanChristopheMorinPerso
requested changes
Dec 16, 2023
src/rez_pip/cli.py
Outdated
Comment on lines
167
to
168
| raise RuntimeError( | ||
| f"No python package found on system for python-{args.python_version}" |
There was a problem hiding this comment.
Suggested change
| raise RuntimeError( | |
| f"No python package found on system for python-{args.python_version}" | |
| ```suggestion | |
| raise rez_pip.exceptions.RezPipError( | |
| f'No "python" package found within the range {args.python_version!r}.' |
By using RezPipError, the error will be nicely integrated and will be consistent with the other errors raised by rez-pip. I also tweaked the error message a bit.
JeanChristopheMorinPerso
approved these changes
Dec 17, 2023
JeanChristopheMorinPerso
merged commit 4d73fcd
into
JeanChristopheMorinPerso:main
18 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a very simple change that is part of an issue I'm currently investigating on why does rez-pip doesn't work on a system.
Adding the exception make it more explicit there is an issue on the python package side, instead of rez-pip just finishing without outputing anything to stdout which make it tricky to debug.
I do not know the side-effect of raising an exception at this level so let me know if you prefer a "softer" solution.