Add support for installing local wheels #75
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanChristopheMorinPerso
force-pushed
the
support_local_wheels
branch
from
ef61dc5
to
f4390eb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 77.76% 75.91% -1.85%
==========================================
Files 8 8
Lines 715 739 +24
Branches 147 157 +10
==========================================
+ Hits 556 561 +5
- Misses 151 170 +19
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jean-Christophe Morin <[email protected]>
JeanChristopheMorinPerso
force-pushed
the
support_local_wheels
branch
from
f4390eb
to
1fd16be
Compare
| if not _path.is_absolute(): | ||
| raise ValueError(f"URI is not absolute: {self.download_info.url!r}") | ||
|
|
||
| return os.fspath(path) |
There was a problem hiding this comment.
The return value is bad when there is a space on Windows. See #74 (comment).
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
git+https://(though that will be though, considering someone can pass anything in requirements files...).