Don't append system PATH to context when finding the python executables #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 77.52% 77.55% +0.03%
==========================================
Files 8 8
Lines 703 704 +1
Branches 146 146
==========================================
+ Hits 545 546 +1
Misses 150 150
Partials 8 8
|
|
I added a test. It's failing on Windows due to an encoding issue. I'm not too sure what's going on. I'll need to take a deeper look at it. But at least the test effectively asserts that the change does what it's supposed to (the test fails if I remove the fix). |
JeanChristopheMorinPerso
force-pushed
the
dont_append_sys_path
branch
3 times, most recently
from
15656f0
to
4aa11e9
Compare
Signed-off-by: Jean-Christophe Morin <[email protected]>
JeanChristopheMorinPerso
force-pushed
the
dont_append_sys_path
branch
from
4aa11e9
to
139aa5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45.
This PR fixes an issue where
ResolvedContext.whichwould return a python executable from outside a rez package.I still need to add a test for this. Creating a PR now to get some visibility.