Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

AST & Parser #5

Draft
wants to merge 40 commits into
base: development
Choose a base branch
from
Draft

AST & Parser #5

wants to merge 40 commits into from

Conversation

JarvisCraft
Copy link
Owner

@JarvisCraft JarvisCraft commented Aug 18, 2020

Description

This PR implements:

Reasoning

The reason for both projects to be implemented via one single PR is that parser is aimed at producing valid AST while the latter's implementation design depends on the former.

Aims

Current aim is to implement the latest specification (i.e. Java SE 15); however, it may happen so that initially only LTS specification (Java SE 8 or Java SE 11) will be fulfilled.

@JarvisCraft JarvisCraft added the enhancement New feature or request label Aug 18, 2020
@JarvisCraft JarvisCraft added this to the v1.0.0 milestone Aug 18, 2020
@pull-assistant
Copy link

pull-assistant bot commented Aug 18, 2020

Score: 0.77

Best reviewed: commit by commit


Optimal code review plan (3 warnings, 2 commits squashed)

     dep: make parser depend on AST

     feat(parser): implement parsing of integral types

test(parser): cover `int_number` rule

javac-rs-parser/src/parser.rs 59% changes removed in refactor(parser): pa...

     refactor(parser): move similar number sub-rules to separate rules

     refactor(parser): remove redundant imports

refactor(parser): ma... ... refactor(parser): pa...

Squashed 2 commits:

     fix(parser): allow upper-case integer prefixes

     feat(parser): implement rule for double numbers

feat(parser): implement rule for float numbers

javac-rs-parser/src/parser.rs 52% changes removed in refactor(parser): mo...

fix(parser): long number parsing

javac-rs-parser/src/parser.rs 50% changes removed in fix(parser): floatin...

     fix(parser): floating-point number parsing

     refactor(parser): move similar floating point number sub-rules to sepa...

     chore(CI): add Travis config

     Merge branch 'development' into ast-parsing

     feat(AST): add basic AST entries and type definitions

     style(AST): add blank line to end of ast.rs

     feat(AST): add missing literal types

     fix(AST): set correct Rust type for Java's long

     fix(AST): make Java type definitions public

     feat(parser): add rules for parsing literals

     feat(parser): implement rules for chars

     style(parser): resolve rustfmt issue with method chaining in parser.rs

Powered by Pull Assistant. Last update 10d819b ... 6a81fd0. Read the comment docs.

@JarvisCraft JarvisCraft changed the title AST & parser AST & Parser Aug 22, 2020
@JarvisCraft JarvisCraft self-assigned this Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant