Dockerize gremlin-server.sh with JanusGraph #141

amcp · 2017-02-26T04:06:13Z

Fixes #140
Signed-off-by: Alexander Patrikalakis [email protected]

hsaputra · 2017-02-26T06:10:16Z

This looks good to me, but how about using Maven Docker plugin like https://github.com/fabric8io/docker-maven-plugin to automate the Docker image building?

amcp · 2017-02-26T06:59:04Z

@hsaputra I think thats a great idea. I'll put in in the master or dist pom in my next pass.

amcp · 2017-02-26T12:03:28Z

@hsaputra I ended up using a different one, but it works now.

pluradj

I tested it out with Docker, and it worked fine. Some small doc updates, then I think this is good to go.

pluradj · 2017-02-28T22:47:49Z

BUILDING.md

+```bash
+docker exec -i -t janusgraph /var/janusgraph/bin/gremlin.sh
+```
+


You should continue this out with some Gremlin Console interaction. The BerkeleyJE backend only allows a single connection, so the users cannot do something like graph = JanusGraphFactory.open('conf/janusgraph-berkeleyje-es.properties') as described in the Getting Started doc.

They would need to configure a remote connection through the Gremlin Server.

gremlin> :remote connect tinkerpop.server conf/remote.yaml ==>Configured localhost/127.0.0.1:8182 gremlin> :remote console ==>All scripts will now be sent to Gremlin Server - [localhost/127.0.0.1:8182] - type ':remote console' to return to local mode gremlin> GraphOfTheGodsFactory.load(graph) ==>null gremlin> g = graph.traversal() ==>graphtraversalsource[standardjanusgraph[berkeleyje:db/berkeley], standard]

will make these changes now

Include:
cd janusgraph-hbase-parent/janusgraph-hbase-core && mvn install

and/or upload to:

https://oss.sonatype.org/content/repositories/snapshots/org/janusgraph/janusgraph-hbase-core/0.1.0-SNAPSHOT/janusgraph-hbase-core-0.1.0-SNAPSHOT-tests.jar

@pluradj done!

hsaputra · 2017-02-28T23:36:30Z

@amcp Looks good to me!

pluradj · 2017-03-01T20:18:14Z

janusgraph-dist/src/assembly/static/conf/gremlin-server/gremlin-server.yaml

@@ -3,7 +3,7 @@ port: 8182
 scriptEvaluationTimeout: 30000
 channelizer: org.apache.tinkerpop.gremlin.server.channel.WebSocketChannelizer
 graphs: {
-  graph: conf/gremlin-server/janusgraph-cassandra-es-server.properties}
+  graph: conf/gremlin-server/janusgraph-berkeleyje-es-server.properties}


This change will make the Chapter 7 JanusGraph server docs incorrect, since they assume that running bin/janusgraph.sh start will start up Cassandra, ES, and Gremlin Server with a graph instance configured to use them.

You could make a separate server YAML for the BerkeleyJE-ES configuration that you can pass to the gremlin server CMD in the Dockerfile.

will make a second YAML file and update the instructions

@pluradj I now pass the path to a separate YAML file for berkeleyje

@pluradj done!

analytically · 2017-03-03T14:58:29Z

janusgraph-dist/janusgraph-dist-hadoop-2/Dockerfile

+
+ENV PATH "$JAVA_HOME/bin:$PATH"
+RUN apt-get update -y
+RUN apt-get install -y zip


run these in one line, less layers

always better to make build thinner and faster !

@analytically am I allowed to combine an ENV directive with a RUN directive? I understand that I can write RUN apt-get update -y && apt-get install -y zip and RUN unzip -q ${server_base}.zip && ln -s ./${server_base} ./janusgraph

No can't do that.

ill batch together what I can.

@analytically done!

amcp · 2017-03-05T19:45:01Z

@pluradj @analytically Look OK?

pluradj · 2017-03-06T17:16:01Z

janusgraph-dist/janusgraph-dist-hadoop-2/Dockerfile

+RUN ln -s ./${server_base} ./janusgraph
+WORKDIR /var/janusgraph
+EXPOSE 8182
+CMD ["./bin/gremlin-server.sh"]


I suggest changing the command here to ./bin/gremlin-server.sh ./conf/gremlin-server/gremlin-server-berkeleyje-es.yaml and creating the new YAML file.

The change to gremlin-server.yaml should be reverted so ./bin/janusgraph.sh start still works as documented with Cassandra and ES.

ok, will do.

@pluradj done!

zifnab87 · 2017-04-21T08:18:44Z

any updates on this? Thanks :)

taylorsmithgg

Build is currently failing for me due to a missing jar: https://oss.sonatype.org/content/repositories/snapshots/org/janusgraph/janusgraph-hbase-core/0.1.0-SNAPSHOT/janusgraph-hbase-core-0.1.0-SNAPSHOT-tests.jar

taylorsmithgg · 2017-04-24T23:03:21Z

Need to make sure to include
cd janusgraph-hbase-parent/janusgraph-hbase-core && mvn install

In order for build to pass.

amcp

addressed feedback

amcp · 2017-04-25T18:25:05Z

janusgraph-dist/janusgraph-dist-hadoop-2/Dockerfile

+
+ENV PATH "$JAVA_HOME/bin:$PATH"
+RUN apt-get update -y
+RUN apt-get install -y zip


@analytically done!

amcp · 2017-04-25T18:25:23Z

BUILDING.md

+```bash
+docker exec -i -t janusgraph /var/janusgraph/bin/gremlin.sh
+```
+


@pluradj done!

amcp · 2017-04-25T18:26:03Z

janusgraph-dist/janusgraph-dist-hadoop-2/Dockerfile

+RUN ln -s ./${server_base} ./janusgraph
+WORKDIR /var/janusgraph
+EXPOSE 8182
+CMD ["./bin/gremlin-server.sh"]


@pluradj done!

amcp · 2017-04-25T18:26:14Z

janusgraph-dist/pom.xml

+                        <plugin>
+                            <groupId>com.spotify</groupId>
+                            <artifactId>docker-maven-plugin</artifactId>
+                            <version>0.4.13</version>


pull tool version up top

amcp · 2017-04-25T18:26:52Z

janusgraph-dist/src/assembly/static/conf/gremlin-server/gremlin-server.yaml

@@ -3,7 +3,7 @@ port: 8182
 scriptEvaluationTimeout: 30000
 channelizer: org.apache.tinkerpop.gremlin.server.channel.WebSocketChannelizer
 graphs: {
-  graph: conf/gremlin-server/janusgraph-cassandra-es-server.properties}
+  graph: conf/gremlin-server/janusgraph-berkeleyje-es-server.properties}


@pluradj done!

amcp · 2017-04-25T18:47:01Z

@pluradj @analytically @hsaputra @taylorsmithgg I've addressed all your feedback
@zifnab87 as soon as this is reviewed and approved, I will merge.

taylorsmithgg

Looking good! Really happy to have this available.

taylorsmithgg · 2017-04-24T23:44:27Z

BUILDING.md

+```bash
+docker exec -i -t janusgraph /var/janusgraph/bin/gremlin.sh
+```
+


Include:
cd janusgraph-hbase-parent/janusgraph-hbase-core && mvn install

and/or upload to:

https://oss.sonatype.org/content/repositories/snapshots/org/janusgraph/janusgraph-hbase-core/0.1.0-SNAPSHOT/janusgraph-hbase-core-0.1.0-SNAPSHOT-tests.jar

sjudeng · 2017-04-29T21:47:48Z

I pushed a branch and PR that uses Compose to start both Elasticsearch and the JanusGraph Gremlin Server container linked to same. I think this is preferable to trying to get ES started within the same container and it might offer easier extension points for later efforts (e.g. adding containers for storage backends, persistent data volumes, etc.).

AndreSteenbergen · 2017-05-03T11:53:14Z

In the docker image it might be wise to listen on 0.0.0.0 instead of localhost

AndreSteenbergen · 2017-05-03T11:55:48Z

janusgraph-dist/src/assembly/static/conf/gremlin-server/gremlin-server-berkeleyje.yaml

@@ -0,0 +1,40 @@
+host: localhost


0.0.0.0 would be nice, so you can expose port 8182 to outside docker container, and connect using websockets for testing clients outside the container.

Didn't catch this before merging. Will start a new PR to address.

sjudeng · 2017-06-01T01:22:46Z

@amcp If you don't mind the added Compose dependency amcp/janusgraph/pull/1 includes all the updates requested above.

janusgraph-bot · 2017-06-03T10:11:04Z

Author of one or more commits is not listed as a CLA signer, either individual or as a member of an organization.

amcp · 2017-06-03T10:12:07Z

@sjudeng I merged in your commit to my pr.
@hsaputra @pluradj Is the some of our work acceptable now?

sjudeng · 2017-06-06T01:39:58Z

@hsaputra, @pluradj, @analytically If possible can you confirm all your requested changes are in here or request additional time for review? Otherwise unless there are objections in 48 hours I can review all your requests and confirm the changes are in and then merge if everything looks resolved.

hsaputra · 2017-06-06T04:09:43Z

LGTM

amcp · 2017-06-06T09:40:44Z

I can rebase and then ask pluradj to take a look.

Signed-off-by: Alexander Patrikalakis <[email protected]>

…rch containers Signed-off-by: sjudeng <[email protected]>

amcp · 2017-06-06T09:57:43Z

@pluradj @sjudeng I rebased the branch so we should be all set to go.

amcp · 2017-06-07T19:22:50Z

@sjudeng 48 hours seem to have passed? Can you merge this please?

sjudeng · 2017-06-07T19:33:07Z

Yep. I'll run through the comments once for good measure and then get it merged later today.

All requests have been resolved and reviewer has had opportunities to provide additional requests..

amcp

forgot to address a comment

amcp · 2017-06-08T02:07:30Z

janusgraph-dist/src/assembly/static/conf/gremlin-server/gremlin-server-berkeleyje.yaml

@@ -0,0 +1,40 @@
+host: localhost


Didn't catch this before merging. Will start a new PR to address.

Expose gremlin server port by listening on 0.0.0.0 #141

Dockerize gremlin-server.sh with JanusGraph

Expose gremlin server port by listening on 0.0.0.0 JanusGraph#141

Dockerize gremlin-server.sh with JanusGraph

Expose gremlin server port by listening on 0.0.0.0 JanusGraph#141

amcp assigned hsaputra and ptgoetz Feb 26, 2017

janusgraph-bot added the cla: yes This PR is compliant with the CLA label Feb 26, 2017

pluradj previously requested changes Feb 28, 2017

View reviewed changes

amcp force-pushed the docker branch from d7d6b31 to 7e701b9 Compare March 1, 2017 13:52

pluradj reviewed Mar 1, 2017

View reviewed changes

amcp mentioned this pull request Mar 3, 2017

Suggestion: Have an official docker image for running this locally/in production amazon-archives/dynamodb-janusgraph-storage-backend#62

Closed

analytically reviewed Mar 3, 2017

View reviewed changes

amcp force-pushed the docker branch 3 times, most recently from 27650eb to b375394 Compare March 3, 2017 15:36

amcp force-pushed the docker branch 2 times, most recently from f1d62d3 to 3170624 Compare March 6, 2017 01:16

pluradj reviewed Mar 6, 2017

View reviewed changes

janusgraph-bot added the cla: yes This PR is compliant with the CLA label Apr 5, 2017

taylorsmithgg suggested changes Apr 24, 2017

View reviewed changes

amcp force-pushed the docker branch from 3170624 to 6557af1 Compare April 25, 2017 18:19

amcp commented Apr 25, 2017

View reviewed changes

amcp force-pushed the docker branch 3 times, most recently from 1a9dc59 to 6337004 Compare April 25, 2017 18:44

taylorsmithgg approved these changes Apr 25, 2017

View reviewed changes

AndreSteenbergen reviewed May 3, 2017

View reviewed changes

janusgraph-bot added cla: no This PR is not compliant with the CLA and removed cla: yes This PR is compliant with the CLA labels Jun 3, 2017

sjudeng approved these changes Jun 3, 2017

View reviewed changes

Alexander Patrikalakis and others added 2 commits June 5, 2017 23:51

Dockerize gremlin-server.sh & JanusGraph with docker plugin

8ea98ff

Signed-off-by: Alexander Patrikalakis <[email protected]>

Use Docker Compose to manage JanusGraph Gremlin Server and Elasticsea…

4c8c414

…rch containers Signed-off-by: sjudeng <[email protected]>

amcp force-pushed the docker branch from b8f8689 to 4c8c414 Compare June 6, 2017 09:54

janusgraph-bot added cla: yes This PR is compliant with the CLA and removed cla: no This PR is not compliant with the CLA labels Jun 6, 2017

sjudeng merged commit 32f468c into JanusGraph:master Jun 7, 2017

amcp deleted the docker branch June 8, 2017 01:55

amcp commented Jun 8, 2017

View reviewed changes

amcp mentioned this pull request Jun 8, 2017

Expose gremlin server port by listening on 0.0.0.0 #141 #308

Merged

sjudeng added a commit that referenced this pull request Jun 8, 2017

Merge pull request #308 from amcp/dockerFix

78a9579

Expose gremlin server port by listening on 0.0.0.0 #141

bwatson-rti-org pushed a commit to bwatson-rti-org/janusgraph that referenced this pull request Mar 9, 2019

Merge pull request JanusGraph#141 from amcp/docker

1eb4a57

Dockerize gremlin-server.sh with JanusGraph

bwatson-rti-org pushed a commit to bwatson-rti-org/janusgraph that referenced this pull request Mar 9, 2019

Merge pull request JanusGraph#308 from amcp/dockerFix

cffc1a7

Expose gremlin server port by listening on 0.0.0.0 JanusGraph#141

micpod pushed a commit to micpod/janusgraph that referenced this pull request Nov 5, 2019

Merge pull request JanusGraph#141 from amcp/docker

0304ec8

Dockerize gremlin-server.sh with JanusGraph

micpod pushed a commit to micpod/janusgraph that referenced this pull request Nov 5, 2019

Merge pull request JanusGraph#308 from amcp/dockerFix

ff8bfb3

Expose gremlin server port by listening on 0.0.0.0 JanusGraph#141

Dockerize gremlin-server.sh with JanusGraph #141

Dockerize gremlin-server.sh with JanusGraph #141

Conversation

amcp commented Feb 26, 2017

hsaputra commented Feb 26, 2017

amcp commented Feb 26, 2017

amcp commented Feb 26, 2017

pluradj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hsaputra commented Feb 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amcp commented Mar 5, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zifnab87 commented Apr 21, 2017

taylorsmithgg left a comment

Choose a reason for hiding this comment

taylorsmithgg commented Apr 24, 2017

amcp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amcp commented Apr 25, 2017

taylorsmithgg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sjudeng commented Apr 29, 2017

AndreSteenbergen commented May 3, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sjudeng commented Jun 1, 2017

janusgraph-bot commented Jun 3, 2017

amcp commented Jun 3, 2017

sjudeng commented Jun 6, 2017

hsaputra commented Jun 6, 2017

amcp commented Jun 6, 2017

amcp commented Jun 6, 2017

amcp commented Jun 7, 2017

sjudeng commented Jun 7, 2017

amcp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amcp commented Mar 5, 2017 •

edited

Loading