Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template for blog posts and development work to improve our blog #130

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

koebel
Copy link
Contributor

@koebel koebel commented May 31, 2024

adding two templates for submitting PRs to our blog

  • BLOG_POST_PULL_REQUEST_TEMPLATE.md is for submitting a blog post
  • DEVELOPMENT_PULL_REQUEST_TEMPLATE.md is for submitting some development improvements in our blog

@koebel koebel requested a review from phil-davis May 31, 2024 10:16
phil-davis
phil-davis previously approved these changes May 31, 2024
individual-it
individual-it previously approved these changes Jun 1, 2024
SagarGi
SagarGi previously approved these changes Jun 1, 2024
@SagarGi
Copy link
Contributor

SagarGi commented Jun 1, 2024

@koebel could you sign all your commits and then only we can merge it.

@koebel
Copy link
Contributor Author

koebel commented Jun 4, 2024

@koebel could you sign all your commits and then only we can merge it.

Thanks for the hint. I've added a GPG key to my GitHub, but it doesn't seem to affect previous commits. @SagarGi do you know if that will be required for merging?

Update: fixed this in the meanwhile with Phil's help. @SagarGi you can ignore the question above.

@koebel koebel requested a review from individual-it June 4, 2024 07:54
@phil-davis phil-davis merged commit 98023d1 into master Jun 4, 2024
1 check passed
@phil-davis phil-davis deleted the blog-PR-template branch June 4, 2024 08:16
@koebel koebel restored the blog-PR-template branch June 26, 2024 06:27
@koebel koebel deleted the blog-PR-template branch June 26, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants