Use HTTP 500 instead of HTTP 400 for generic errors

CHANGELOG.md

@@ -9,6 +9,7 @@
 * Disable "eco" mode switch on older units (https://github.com/Jalle19/eda-modbus-bridge/issues/104)
 * Add optional sensors for control panel temperature, supply fan speed and exhaust fan speed (https://github.com/Jalle19/eda-modbus-bridge/issues/96)
 * Remove references to "flags", use "modes" everywhere instead
+* Use HTTP 500 instead of HTTP 400 for generic errors
 
 ## 2.7.1
 

README.md

@@ -263,7 +263,7 @@ The response is identical to that of `GET /mode/{mode}`.
 
 ### POST /setting/{setting}/{value}
 
-Changes the setting to the specified value. HTTP 400 is thrown if the value specified is out of range or invalid.
+Changes the setting to the specified value. HTTP 400 is returned if the value specified is out of range or invalid.
 
 Returns the new setting values, like this:
 

app/http.mjs

@@ -80,7 +80,11 @@ const setSetting = async (modbusClient, req, res) => {
             'settings': await getSettings(modbusClient),
         })
     } catch (e) {
-        handleError(e, res)
+        if (e instanceof RangeError) {
+            handleError(e, res, 400)
+        } else {
+            handleError(e, res)
+        }
     }
 }
 
@@ -100,8 +104,9 @@ export const configureRoutes = (httpServer, modbusClient) => {
     })
 }
 
-const handleError = (e, res) => {
+const handleError = (e, res, statusCode = undefined) => {
     logger.error(`An exception occurred: ${e.name}: ${e.message}`, e.stack)
-    res.status(400)
+    // Use HTTP 500 if no status code has been set
+    res.status(statusCode ?? 500)
     res.json(e)
 }